Closed Bug 1512086 Opened 2 years ago Closed 2 years ago
Highlighter does not work
47 bytes, text/x-phabricator-request
|Details | Review|
**Steps to reproduce** 1. Go to `data:text/html,<meta charset=utf8>` 2. Open the console (directly, it's important) 3. Evaluate `document.body` 4. In the output, hover the `<body>` element **Expected results** The body is highlighted in the content page **Actual results** The highlighter does not work --- Note that it works if at some point you open the inspector.
Oh this is bad. I would probably prioritize this higher than a P3. This is a major feature of the console that just doesn't work anymore. I'm currently running a mozregression to find out what caused this regression. It'd be great to fix it with 65.
Mozregression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bd2ec1be4ead26c0e0a7620d7f963b7934e37319&tochange=5f6b602fb590ccbaab9a33474d72a0aacdbd5529 Bug that caused the regression: bug 1508655
Somehow I think `toolbox.initInspector()` isn't called anymore before trying to highlight from the console. I think it used to be, and that's what is making this break now, because without it, the code realizes that the highlighter isn't ready, and bails out.
Thanks for investigating Patrick
Priority: P3 → P2
Yulia, would you know what's happening now?
Also, https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/devtools/client/webconsole/test/mochitest/browser_webconsole_nodes_highlight.js should probably be re-written to not open the inspector (which would have caught this bug)
Yes, i think i know what is happening. I will take a look.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5ca5e911d32f fix console highlighting and update test to fail if it doesnt; r=nchevobbe
Assignee: nobody → ystartsev
I can reproduce this following str from comment 0 with Nightly 65.0a1 (2018-12-05). I can verify that this issue is fixed in Latest Beta 65.0b7 in Linux x86_64. Build ID 20181227144402 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0 [bugday-20190102]
I have reproduced this bug with Nightly 65.0a1 (2018-12-04) in Windows 7, 64 bit. This bug's fix is verified with latest Beta 65.0b8! Build ID 20190103150357 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0 [bugday-20190102]
You need to log in before you can comment on or make changes to this bug.