1512110 - Implement selection/highlighting

Status: RESOLVED DUPLICATE of bug 1492842

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

The up/down arrow keys should move the selection through the popup, and we should be storing selection state somewhere -- in the controller IMO.

I'm marking this as blocking the autofill bug, bug 1511530, even though it's probably not strictly necessary.  But I think it would be helpful to have the selection story written before we nail down the heuristic-result story, which encompasses autofill.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1512110 - Implement QuantumBar selection/highlighting.

It seems to me that selection state belongs in the controller.  Selection changes start via user events, are passed on to the controller, which updates the selection state, and then the controller notifies its listeners of the changes.  There are a couple of selection-change listeners: the view, so it can update the highlight/selection in the popup, and the input, so it can set its value to the value of the selected result.

Comment 2

[Dão Gottwald [:dao]]

D'oh, we had already filed bug 1492842 for this, and I made a patch yesterday...