Closed Bug 1512215 Opened 10 months ago Closed 10 months ago

Port bug 1429940: Use HTML headings to improve accessibility of groups in Preferences

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

M-c removed almost all <caption>. Should we follow?
Jörg, what do you think, should we follow. Maybe they are planning to remove <caption>.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9029632 - Flags: review?(jorgk)
Let's see whether that affects tests since we might be looking for the captions:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=bc2a64b5845832674ac56f47dcaba1e72e223eca
Comment on attachment 9029632 [details] [diff] [review]
1512215-caption-to-label.patch

No test failures. Did you do this by hand? How am I supposed to check the use of <label class="header"> vs. <label><html:h2>?
Attachment #9029632 - Flags: review?(jorgk) → review+
Yes, by hand in editor with the text exchange function. But it had different occurrences with additional IDs or classes which needed manual changes.

<label class="header"> is used in all normal XUL dialogs, windows etc. <label><html:h2> is only used in the in-content preferences files.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f51f341a4d9c
Port bug 1429940, part 2: Use HTML headings inside the "label" element for labeling "groupbox" elements in Preferences instead of the "caption" element. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.