1512274 - Support checkstyle for GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

This is to track support for checkstyle in GeckoView.

Comment 1

[Chris Peterson [:cpeterson]]

P3 nice to have

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Don't change value of method arguments.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Add final to all methods in GeckoView.

Depends on D23682

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Make all argument names be lowerCamelCase.

Depends on D23683

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Make all constants actually final.

Depends on D23684

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Make all local variables be lowerCamelCase.

Depends on D23685

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Make all private member variable be mCamelCase.

Depends on D23686

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] LeftCurly checkstyle fixes

Depends on D23687

Comment 9

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Fix indentation.

Depends on D23688

Comment 10

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Avoid star imports.

Depends on D23689

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - [geckoview] Remove unused imports.

Depends on D23690

Comment 12

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1512274 - Enable Checkstyle for GeckoView.

Depends on D23691

Comment 13

[[ex-Mozilla] Agi Sferro | :agi]

try runs:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b197b5c406f57fc2e6dd8a11e39cc522d4bfdaf
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4b10f00d245810e0f7f9da8c6cbcd98e70805ae

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3812d6760379
[geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/58642fa9c95b
[geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/380cdbe5557c
[geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/5d02f27fe174
[geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/60897ab00574
[geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/c34445b1db88
[geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/161731389a46
[geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/670e07131f14
[geckoview] Fix indentation. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/9a9d3c9c124a
[geckoview] Avoid star imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/6ca9fc4956d0
[geckoview] Remove unused imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/9f34d0075a73
Enable Checkstyle for GeckoView. r=geckoview-reviewers,nalexander,snorp

Comment 15

[Narcis Beleuzu [:NarcisB]]

Backed out for TL bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1f911d12fd0737a2107c8b0cc98cf3d62165d7db
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=9f34d0075a7300366203a37ac0155aa2198fdf7a&selectedJob=234211675
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234211675&repo=autoland&lineNumber=1072

Comment 16

[[ex-Mozilla] Agi Sferro | :agi]

Discussed over IRC, this push wasn't causing the problem. I'm resubmitting the patches. Thank you!

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/341fa541129c
[geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/c67154ec3047
[geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/109fc6275c26
[geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/019476ee908e
[geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/eedd3b996ae5
[geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/4253ecfe57e9
[geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/6f9896e3f39a
[geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/e96e3b52009e
[geckoview] Fix indentation. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/0e3e8c310f2f
[geckoview] Avoid star imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/e9a3857031e1
[geckoview] Remove unused imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/08d9090316cf
Enable Checkstyle for GeckoView. r=geckoview-reviewers,nalexander,snorp

Comment 18

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/341fa541129c
https://hg.mozilla.org/mozilla-central/rev/c67154ec3047
https://hg.mozilla.org/mozilla-central/rev/109fc6275c26
https://hg.mozilla.org/mozilla-central/rev/019476ee908e
https://hg.mozilla.org/mozilla-central/rev/eedd3b996ae5
https://hg.mozilla.org/mozilla-central/rev/4253ecfe57e9
https://hg.mozilla.org/mozilla-central/rev/6f9896e3f39a
https://hg.mozilla.org/mozilla-central/rev/e96e3b52009e
https://hg.mozilla.org/mozilla-central/rev/0e3e8c310f2f
https://hg.mozilla.org/mozilla-central/rev/e9a3857031e1
https://hg.mozilla.org/mozilla-central/rev/08d9090316cf