Closed Bug 1512274 Opened Last year Closed 10 months ago

Support checkstyle for GeckoView

Categories

(GeckoView :: General, enhancement, P3)

enhancement

Tracking

(firefox65 wontfix, firefox66 wontfix, firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: Agi, Assigned: Agi)

References

Details

Attachments

(11 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
This is to track support for checkstyle in GeckoView.
Product: Firefox for Android → GeckoView
P3 nice to have
Priority: -- → P3

Depends on D23687

Depends on D23688

Depends on D23689

Depends on D23690

Depends on D23691

Assignee: nobody → agi
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3812d6760379
[geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/58642fa9c95b
[geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/380cdbe5557c
[geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/5d02f27fe174
[geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/60897ab00574
[geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/c34445b1db88
[geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/161731389a46
[geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/670e07131f14
[geckoview] Fix indentation. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/9a9d3c9c124a
[geckoview] Avoid star imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/6ca9fc4956d0
[geckoview] Remove unused imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/9f34d0075a73
Enable Checkstyle for GeckoView. r=geckoview-reviewers,nalexander,snorp

Discussed over IRC, this push wasn't causing the problem. I'm resubmitting the patches. Thank you!

Flags: needinfo?(agi)
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/341fa541129c
[geckoview] Don't change value of method arguments. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/c67154ec3047
[geckoview] Add final to all methods in GeckoView. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/109fc6275c26
[geckoview] Make all argument names be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/019476ee908e
[geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/eedd3b996ae5
[geckoview] Make all local variables be lowerCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/4253ecfe57e9
[geckoview] Make all private member variable be mCamelCase. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/6f9896e3f39a
[geckoview] LeftCurly checkstyle fixes r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/e96e3b52009e
[geckoview] Fix indentation. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/0e3e8c310f2f
[geckoview] Avoid star imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/e9a3857031e1
[geckoview] Remove unused imports. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/08d9090316cf
Enable Checkstyle for GeckoView. r=geckoview-reviewers,nalexander,snorp
Regressions: 1550185
Regressions: 1566704
You need to log in before you can comment on or make changes to this bug.