Devtools tab icons should have empty alt attribute

RESOLVED FIXED in Firefox 65

Status

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: fvsch, Assigned: fvsch)

Tracking

unspecified
Firefox 65

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
Currently the devtools tab icons have no alt attribute. Since we already have a label (and a title on the parent button), we should probably use alt="" so that screen readers don't try to read the filename instead.

<button>
  <img src="tool-accessibility.svg">
  <span>Accessibility</span>
</button>

Might be read as:

"tool dash accessibility dot S.V.G. accessibility"

We want it read as just "Accessibility", so we need:

<button>
  <img src="tool-accessibility.svg" alt="">
  <span>Accessibility</span>
</button>

It should be a one-line change in devtools/client/framework/components/ToolboxTab.js
Assignee

Updated

6 months ago
Assignee: nobody → florens
Status: NEW → ASSIGNED

Comment 2

6 months ago
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/17e2efc3d047
add empty alt text to ToolboxTab icon; r=pbro

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/17e2efc3d047
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.