Closed Bug 1512278 Opened 6 years ago Closed 6 years ago

Devtools tab icons should have empty alt attribute

Categories

(DevTools :: Framework, enhancement)

enhancement
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

Details

Attachments

(1 file)

Currently the devtools tab icons have no alt attribute. Since we already have a label (and a title on the parent button), we should probably use alt="" so that screen readers don't try to read the filename instead.

<button>
  <img src="tool-accessibility.svg">
  <span>Accessibility</span>
</button>

Might be read as:

"tool dash accessibility dot S.V.G. accessibility"

We want it read as just "Accessibility", so we need:

<button>
  <img src="tool-accessibility.svg" alt="">
  <span>Accessibility</span>
</button>

It should be a one-line change in devtools/client/framework/components/ToolboxTab.js
Assignee: nobody → florens
Status: NEW → ASSIGNED
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/17e2efc3d047
add empty alt text to ToolboxTab icon; r=pbro
https://hg.mozilla.org/mozilla-central/rev/17e2efc3d047
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: