Run windows10 AWSY on virtual-with-gpu

RESOLVED FIXED in Firefox 65

Status

defect
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

(Blocks 1 bug)

Version 3
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

6 months ago
Right now non-webrender AWSY runs on a VM without a GPU, which measures an unaccelerated experience. This is hard to compare apples-to-apples with WebRender, which requires a GPU.

In bug 1509974 comment 5, I proposed moving the existing windows10 AWSY tests to virtual-with-gpu, so that we have have a comparable baseline.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e10637044bdceb089ea26fbb2f6b38c8c5e2fcb1
Assignee

Comment 3

6 months ago
Depends on D13963
Assignee

Comment 4

6 months ago
Depends on D13964

Comment 5

6 months ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1b3f3624b87
Support an environmental variable to force-disable WebRender. r=kats
https://hg.mozilla.org/integration/autoland/rev/929fe0acd506
Use the env var on non-QR platforms. r=kats
https://hg.mozilla.org/integration/autoland/rev/cd601d93d9f3
Force non-QR onto virtual-with-gpu. r=kats

Comment 8

6 months ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/47035a397239
Support an environmental variable to force-disable WebRender. r=kats
https://hg.mozilla.org/integration/autoland/rev/4d90a83e78cf
Use the env var on non-QR platforms. r=kats
https://hg.mozilla.org/integration/autoland/rev/1c9251fcdc67
Force non-QR onto virtual-with-gpu. r=kats
Assignee

Comment 9

6 months ago
Here's a before-after comparison on memory: https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=639cfcee65d14c53aa56fd10c9535e1c7f4beeba&framework=4&filter=windows10&showOnlyComparable=1&selectedTimeRange=172800

Explicit is mostly unchanged, and Resident gets significantly worse. This almost certainly corresponds to VirtualAlloc calls in the graphics driver, which is exactly what we'd expect here. Comparison of memory reports shows the increase primarily coming in increases in commit/private/readwrites{,+writecombine}, which also supports this theory.

So we should expect a ~18.5% regression in AWSY resident, and treat it as a baseline update. Eric, can you acknowledge?
Flags: needinfo?(erahm)
Assignee

Comment 11

6 months ago
Attaching some before/after memory reports for comparison.

Comment 12

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47035a397239
https://hg.mozilla.org/mozilla-central/rev/4d90a83e78cf
https://hg.mozilla.org/mozilla-central/rev/1c9251fcdc67
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1512987
(In reply to Bobby Holley (:bholley) from comment #9)
> Here's a before-after comparison on memory:
> https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-
> central&newProject=try&newRevision=639cfcee65d14c53aa56fd10c9535e1c7f4beeba&f
> ramework=4&filter=windows10&showOnlyComparable=1&selectedTimeRange=172800
> 
> Explicit is mostly unchanged, and Resident gets significantly worse. This
> almost certainly corresponds to VirtualAlloc calls in the graphics driver,
> which is exactly what we'd expect here. Comparison of memory reports shows
> the increase primarily coming in increases in
> commit/private/readwrites{,+writecombine}, which also supports this theory.
> 
> So we should expect a ~18.5% regression in AWSY resident, and treat it as a
> baseline update. Eric, can you acknowledge?

No surprises after landing, thanks for testing ahead of time.
Flags: needinfo?(erahm)
You need to log in before you can comment on or make changes to this bug.