1512331 - Item IFrame not considering recurrence dates (rule.untilDate is undefined)

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: fix against comm-central

STR:
0. Thunderbird 60.3.0, clean profile, Lightning enabled.
1. Create a sequence of events (for example repeating daily)
2. Copy a single instance of the sequence
3. Paste the instance somewhere in the calendar
4. Double-click on the new instance

Expected:
Window to edit the event opens, no errors in error console

Actual:
Window to edit the event opens, error console logs:
> TypeError: rule.untilDate is undefined
>  updateRepeat chrome://lightning/content/lightning-item-iframe.js:2599:17
>  updateCalendar chrome://lightning/content/lightning-item-iframe.js:2491:9
>  loadDialog chrome://lightning/content/lightning-item-iframe.js:730:9
>  onLoad chrome://lightning/content/lightning-item-iframe.js:380:5
>  onload chrome://lightning/content/lightning-item-iframe.xul:1:1

As updateRepeat is not finishing, there could also be some update issues and Add-ons relying on updateRepeat change their behavior – that's how I found the bug.

Reason:
lightning-item-iframe.js:2598-2599 is (comm-central:2720-2721)
> if (!rule.isByCount && rule.isFinite) {
>   gUntilDate = rule.untilDate.clone().getInTimezone(cal.dtz.defaultTimezone);
assuming that "rule" is a calIRecurrenceRule, but in this case it's a
calIRecurrenceDate, which doesn't implement isByCount. rule.untilDate is also
not implemented – attempting to clone undefined obviously fails.

Fix:
It seems to me that lightning-item-iframe.js globally assumes that the first positive recurrence item is a calIRecurrenceRule. In most cases, that works, as accessing isFinite and untilDate yields a falsy value for both rules and dates. If one wants to keep the style this bug can be fixed by checking untilDate before cloning; I attached a patch for that, as I assume the current style was conceived for a reason (performance?).

If there was no particular reason to violate the interfaces, it might be a better idea to fix this bug differently: for example by limiting splitRecurrenceRules to positive rules or checking the recurrence items' type before accessing rule-only members.

Comment 1

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: fix against comm-central

Sorry, forgot the patch header. This *should* satisfy the requirements.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9029753 [details] [diff] [review]
fix against comm-central

Review of attachment 9029753 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like a reasonable fix, thanks for digging in!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/13f5e1afe5a3
Don't access undefined untilDate on calIRecurrenceDate. r=philipp