1512432 - Convert <richlistitem> to Custom Element

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Brian Grinstead [:bgrins]]

The binding itself looks pretty easy: https://bgrins.github.io/xbl-analysis/tree/#richlistitem.

I assume the tricky part will be covering inherited bindings at the same time. That might have to happen all at once, and there may be some flattening there that could happen as well (like the autocomplete-profile-* bindings).

Comment 1

[Brian Grinstead [:bgrins]]

It doesn't look like the base richlistitem does much on connection so I don't anticipate perf problems on that. But some of the inherited bindings set <content>, so if there are hidden instances of those there could be potential regressions.

Comment 2

[Brian Grinstead [:bgrins]]

Here's a try push that does just the base binding: https://treeherder.mozilla.org/#/jobs?repo=try&revision=977c38236965e5f22959f89ef83626604595874e&selectedJob=215748047

Comment 3

[alexander :surkov (:asurkov)]

(In reply to Brian Grinstead [:bgrins] from comment #0)

The binding itself looks pretty easy:
https://bgrins.github.io/xbl-analysis/tree/#richlistitem.

I assume the tricky part will be covering inherited bindings at the same
time. That might have to happen all at once, and there may be some
flattening there that could happen as well (like the autocomplete-profile-*
bindings).

All (currently) dependent bindings will go away when new about:addons is landed, the codebase already has MozRichlistitem, so the bug fix is rather trivial:

• add customElements.define("richlistitem", MozRichlistitem); into richlistbox.js
• remove richlistitem binding in xul.css

Brian, does anything prevent us from replacing richlistitem binding on CE now (leaving all dependent bindings untouched for sure)?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to alexander :surkov (:asurkov) from comment #3)

(In reply to Brian Grinstead [:bgrins] from comment #0)

The binding itself looks pretty easy:
https://bgrins.github.io/xbl-analysis/tree/#richlistitem.

I assume the tricky part will be covering inherited bindings at the same
time. That might have to happen all at once, and there may be some
flattening there that could happen as well (like the autocomplete-profile-*
bindings).

All (currently) dependent bindings will go away when new about:addons is landed, the codebase already has MozRichlistitem, so the bug fix is rather trivial:

• add customElements.define("richlistitem", MozRichlistitem); into richlistbox.js
• remove richlistitem binding in xul.css

Brian, does anything prevent us from replacing richlistitem binding on CE now (leaving all dependent bindings untouched for sure)?

The problem is that then about:addons would have both a CE and XBL attached to richlistitem. I suppose we could skip that document before doing customElements.define() (perhaps based on an attribute on the root node or something so that we don't have to hardcode the URL), but we still couldn't remove the XBL implementation. Might be a good idea anyway to get that flipped and catch any issues early so when about:addons goes away we can delete it.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: Bug 1512432 - convert richlistitem binding to Custom Element, r=bgrins

Comment 6

[alexander :surkov (:asurkov)]

tweak the summary, leaving bug 1505924 for inherited bindings

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e09471d13659
convert richlistitem binding to Custom Element, r=bgrins

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e09471d13659