1512449 - Unexpected UpdateTransformLayer assertion failure

Status: RESOLVED WORKSFORME

(DevTools :: Framework, defect, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1512449 - devtools.dump.emit fails for arrays of nodeFronts r?jdescottes!

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

It is hard to properly debug this due to bug 1512483 but I will add a test case.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

It is an assertion so it is only thrown in debug mode:

ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file /builds/worker/workspace/build/src/layout/base/RestyleManager.cpp, line 1150

And the failed assertion is here:
https://searchfox.org/mozilla-central/source/layout/base/RestyleManager.cpp

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

That should have been https://searchfox.org/mozilla-central/source/layout/base/RestyleManager.cpp#1147-1150

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Stack:

JavaScript error: resource://devtools/client/shared/telemetry.js, line 148: Error: TelemetryStopwatch: requesting elapsed time for nonexisting stopwatch. Histogram: "DEVTOOLS_FLEXBOX_HIGHLIGHTER_TIME_ACTIVE_SECONDS", key: ""
console.log: "[DISPATCH] action type:" "UPDATE_FLEXBOX_HIGHLIGHTED"
[Parent 36404, Main Thread] ###!!! ASSERTION: Unexpected UpdateTransformLayer hint: '!(aChange & nsChangeHint_UpdateTransformLayer) || aFrame->IsTransformed() || aFrame->StyleDisplay()->HasTransformStyle()', file /Users/ratcliffes/Desktop/firefox/layout/base/RestyleManager.cpp, line 1150
#01: mozilla::RestyleManager::DoProcessPendingRestyles(mozilla::ServoTraversalFlags)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3e13ecb]
#02: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3deec70]
#03: nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3dbebe6]
#04: mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3dc6216]
#05: mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3dc6095]
#06: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3dc79d2]
#07: mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::ParentProcessVsyncNotifier::Run()[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3dc4e6e]
#08: nsThread::ProcessNextEvent(bool, bool*)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x14276f]
#09: NS_ProcessPendingEvents(nsIThread*, unsigned int)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x13fa1e]
#10: nsBaseAppShell::NativeEventCallback()[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3b1d0ef]
#11: nsAppShell::ProcessGeckoEvents(void*)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3b92d69]
#12: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0xa3a11]
#13: __CFRunLoopDoSource0[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x15d42c]
#14: __CFRunLoopDoSources0[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x86470]
#15: __CFRunLoopRun[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x858ed]
#16: CFRunLoopRunSpecific[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x85153]
#17: RunCurrentEventLoopInMode[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x2fd96]
#18: ReceiveNextEventCommon[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x2fb06]
#19: _BlockUntilNextEventMatchingListInModeWithFilter[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x2f884]
#20: _DPSNextEvent[/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x41a73]
#21: -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x7d7e34]
#22: -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:][/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3b91d1e]
#23: -[NSApplication run][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x36885]
#24: nsAppShell::Run()[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3b93710]
#25: nsAppStartup::Run()[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x542d049]
#26: XREMain::XRE_mainRun()[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x55adb14]
#27: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x55ae97a]
#28: XRE_main(int, char**, mozilla::BootstrapConfig const&)[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/XUL +0x55af99d]
#29: main[/Users/ratcliffes/Desktop/firefox/objdir.noindex/dist/NightlyDebug.app/Contents/MacOS/firefox +0xf6d]

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I can no longer reproduce this issue, closing.