Convert datetime-popup to a lazily loaded JSM

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

(Blocks 2 bugs)

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

The only user of datetime-popup implementation is DateTimePickerParent.jsm -- change the caller there will allow us to convert it to another JSM or a custom element.

We couldn't simplify this by merging it to DateTimePickerParent.jsm [1]; it init()s in BrowserGlue._onFirstWindowLoaded().

[1] https://searchfox.org/mozilla-central/rev/adec563403271e78d1a057259b3e17fe557dfd91/browser/components/nsBrowserGlue.js#1355
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #0)
> We couldn't simplify this by merging it to DateTimePickerParent.jsm [1]; it
> init()s in BrowserGlue._onFirstWindowLoaded().

Well, perhaps that's not really a problem given there are only a few hundred lines, not thousands.
Component: XBL → XUL Widgets
Product: Core → Toolkit
I've got a patch!
Assignee: nobody → timdream
Status: NEW → ASSIGNED
See Also: → 1423498
Summary: Convert datetime-popup to a lazily loaded custom element → Convert datetime-popup to a lazily loaded JSM

Updated

6 months ago
Priority: -- → P3

Comment 5

5 months ago
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c41d930784a8
Convert datetime-popup binding to a JSM r=Felipe

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c41d930784a8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Updated

4 months ago
Depends on: 1522779
You need to log in before you can comment on or make changes to this bug.