1512493 - Disable switching tabs by scrolling in the tab bar when it doesn't overflow when not part of platform convention

Status: VERIFIED FIXED

(Toolkit :: XUL Widgets, defect, P2)

Description

[Asif Youssuff]

Bug 1285812 "fixed" an issue where users desired tab switching on mousewheel scroll. This is a nice feature if users are expecting or are used to it, but has been removed from GTK3 (for example), and as such is not expected when using GNOME. 

GNOME Web no longer switches tabs when mousewheel scrolled over tabs, and ideally, Firefox would match. 

I don't have much experience with KDE, but this may be standard there, so I think the best course of action is to match platform convention based on the desktop environment that the user is running; just running on Linux, unfortunately does not provide enough information to Firefox what the actual user expectation is.

Comment 1

[Dão Gottwald [::dao]]

This behavior is currently ifdef'd:

https://searchfox.org/mozilla-central/rev/adec563403271e78d1a057259b3e17fe557dfd91/toolkit/content/widgets/tabbox.xml#357

Should be easy to make that pref-controlled instead, possibly off by default if that's indeed native Gtk3 behavior.

Comment 2

[Asif Youssuff]

Also opened https://gitlab.gnome.org/GNOME/gtk/issues/1501 in GNOME to replicate the existing (pre-65) Firefox behavior of scrolling through the tab bar without switching at the toolkit level. 

This doesn't change the fact that GNOME doesn't support switching via mouse wheel at all, but is intended to bring the desirable macOS/Windows tab scroll behavior to GTK.

Posting here as an FYI; not strictly relevant to the bug here.

Comment 3

[Kestrel]

Better to block the regressing bug.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Aaron, can you take a look at this bug as well as bug 1285812 to see if we should go forward with shipping this behavior change?

Comment 5

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Changing the priority to p2 as the bug is tracked by a release manager for the current beta.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 6

[Dão Gottwald [::dao]]

Attachment: Bug 1512493 - Make switching tabs by scrolling pref-controlled and off by default. r=stransky

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52bc1477d801
Make switching tabs by scrolling pref-controlled and off by default. r=stransky

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/52bc1477d801

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Thanks for doing this, Dão. Please nominate for Beta approval when you get a chance.

Comment 10

[Aaron Benson]

This is okay to uplift to beta.

Comment 11

[Mike de Boer [:mikedeboer]]

Comment on attachment 9035258 [details]
Bug 1512493 - Make switching tabs by scrolling pref-controlled and off by default. r=stransky

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1285812

User impact if declined: This makes the swith-tab-on-scroll behavior, as implemented in bug 1285812, opt-in, matching the current behavior in GTK3.
This introduces a new pref - 'toolkit.tabbox.switchByScrolling' - which turns this behavior ON with set to true in about:config or in the distribution-specific preferences.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This updates the behavior to match that of the latest GTK version(s), now gated by a pref, not by introducing a risky change.

String changes made/needed: n/a.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9035258 [details]
Bug 1512493 - Make switching tabs by scrolling pref-controlled and off by default. r=stransky

[Triage Comment]
Per UX and the various bugs discussing this, I agree with putting this behind a pref for now. Approved for 65.0b11.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8574d2808aaa

Comment 14

[Catalin Sasca, QA [:csasca]]

I verified the pref "toolkit.tabbox.switchByScrolling" and it is off by default and the scroll function in tab bar doesn't work only if the pref's value is changed to true. Tests were performed on Firefox Beta 65.0b11 and latest Nightly 66.0a1 (2019-01-14) under Ubuntu 16.04 (x64).

Comment 15

[Adrian]

Works fine on Windows as well (tested with today's nightly and 65.0b11) - very nice! :)

Any plans to add additional prefs to control:
(1) whether to allow changing tabs by scrolling in case of an overflowing tab bar as well
(2) whether to wrap at the end/beginning of the tab bar (ie scrolling past the last tab going back to the first tab)

Previously I was using this workaround which supported both of the things I mentioned above (not sure why (1) worked there tbh):
https://forum.manjaro.org/t/howto-enable-tab-switching-in-firefox-using-mouse-wheel/39954

I wouldn't mind submitting a patch for this (especially (2), since (1) looks trickier and more risky to break something unrelated since it seems to be handled by code in scrollbox which may or may not be used elsewhere) if it has a decent chance to get merged.