Closed Bug 1512499 Opened 6 years ago Closed 6 years ago

Handle psutil returning None for physical_cores

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox66 fixed)

RESOLVED FIXED
Tracking Status
firefox66 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

sewardj reports that the telemetry code raises a schema validation error building in an aarch64 qemu instance because psutil returns None for physical core count. There's an issue filed upstream for psutil for this: https://github.com/giampaolo/psutil/issues/1359 We should just detect this and not set the field when it's None.
psutil has a bug on arm systems where it will return None for physical_cores: https://github.com/giampaolo/psutil/issues/1359 This causes us to generate invalid telemetry data which raises an error. Fix this by simply omitting the field in this case.
Pushed by tmielczarek@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be66f8877e46 handle psutil returning None for physical_cores. r=froydnj
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: