Closed Bug 1512500 Opened 1 year ago Closed 6 months ago

Record parent docshell in profile JSON pages array

Categories

(Core :: Gecko Profiler, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox65 --- wontfix
firefox71 --- fixed

People

(Reporter: mstange, Assigned: canova)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

At the moment, the pages array has a boolean "isSubframe", but for subframes it doesn't point at the parent docshell. Knowing the parent docshell would be useful so that the UI can create a tree of all docshells, and it would also allow the UI to filter markers by "all docshells which are descendants of the selected docshell".

So we should add a field parentDocshellId to the JSON.
Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Tentatively assigning as P1, as it's for work that we are planning on doing in the short term, although perhaps it's a P2.
Priority: -- → P1

If there is a redirections with a meta tag inside an iframe, we are loading an
about:blank URL and then loading the redirected URL with the same docshell id
and docshell history id. That's why we are getting some duplicate entries and
we don't want that. So it seems like the best solution is to reject registering
about:blank entries altogether.

Attachment #9040669 - Attachment is obsolete: true
Attachment #9040670 - Attachment is obsolete: true
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1bebf33be0d5
Record parent page information in profiler r=gerald,nika
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.