1512500 - Record parent docshell in profile JSON pages array

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P1)

Description

[Markus Stange [:mstange]]

At the moment, the pages array has a boolean "isSubframe", but for subframes it doesn't point at the parent docshell. Knowing the parent docshell would be useful so that the UI can create a tree of all docshells, and it would also allow the UI to filter markers by "all docshells which are descendants of the selected docshell".

So we should add a field parentDocshellId to the JSON.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

Tentatively assigning as P1, as it's for work that we are planning on doing in the short term, although perhaps it's a P2.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1512500 - Do not register `about:blank` URIs as pages since they don't change IDs in iframes r?bzbarsky

If there is a redirections with a meta tag inside an iframe, we are loading an
about:blank URL and then loading the redirected URL with the same docshell id
and docshell history id. That's why we are getting some duplicate entries and
we don't want that. So it seems like the best solution is to reject registering
about:blank entries altogether.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1512500 - Record parent page information in profiler r?mstange,bzbarsky

Depends on D18331

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1512500 - Record parent page information in profiler r?gerald,nika

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bebf33be0d5
Record parent page information in profiler r=gerald,nika

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1bebf33be0d5