1512524 - IsImageFrame checks in tree are incorrect

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

Description

[Timothy Nikkel (:tnikkel)]

Generally we want to be checking if it is an image frame or an image control frame, the latter being a subclass with very few differences.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: fixisimageframechecks

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9029877 [details] [diff] [review]
fixisimageframechecks

Review of attachment 9029877 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +4511,2 @@
>      // Image layer doesn't support draw focus ring for image map.
>      nsImageFrame* f = static_cast<nsImageFrame*>(mFrame);

Actually weren't these checks really ok? Do we support image maps in image controls?

Comment 3

[Daniel Holbert [:dholbert]]

I confess I am not sure. I was suspecting tn was surer than I. tn? :)

Comment 4

[Emilio Cobos Álvarez [:emilio]]

I mean, it's not incorrect anyways, but I _think_ imagecontrolframe + imagemap can't happen.

Comment 5

[Timothy Nikkel (:tnikkel)]

Yeah, I made a testcase, it does indeed work.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2998e60b98b
Make all in-tree IsImageFrame checks also check for IsImageControlFrame because that is what they actually want. r=dholbert

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a2998e60b98b