XUL Overlay Loader doesn't handle insertafter attribute according to the documentation

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: nONoNonO, Assigned: darktrojan)

Tracking

(Blocks 1 bug)

unspecified
Thunderbird 66.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird65 fixed, thunderbird66 fixed)

Details

()

Attachments

(1 attachment)

Reporter

Description

6 months ago
According to the documentation, the insertafter attribute should insert the new node after the first id found in the comma separated list. This was indeed the behavior I was experiencing in my add-on Mail Redirect in Thunderbird 60.* and before.

In Thunderbird 65 however, the new element is inserted after the last id found in the list.

There's of course a workaround, by specifying insertafter="a,b,a", but it would be best if the XUL Overlay Loader did this the same way it used to work.

P.S. The same problem might apply to the insertbefore attribute, but I didn't use that in combination with a comma separated list in my add-on and I haven't tried it.
Assignee

Comment 1

5 months ago
I've tested this against ESR60 and the comment in the code is just wrong.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9032388 - Flags: review?(philipp)
Comment on attachment 9032388 [details] [diff] [review]
1512581-overlay-insertorder-1.diff

Review of attachment 9032388 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, you are right. Not sure what I was thinking there.
Attachment #9032388 - Flags: review?(philipp) → review+

Comment 3

5 months ago
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8a7f1cf1ba4e
Match original behaviour of insertbefore/insertafter attributes; r=Fallen DONTBUILD
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Assignee

Updated

5 months ago
Target Milestone: --- → Thunderbird 66.0

Updated

5 months ago
Attachment #9032388 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.