Windows system modal dialogs should not be reported as hangs

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
8 months ago
3 months ago

People

(Reporter: florian, Assigned: florian, NeedInfo)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

The most common stack currently reported as hangs is when we call CFileOpenSave::Show (from nsFilePicker::ShowFilePicker). PrintDlgW is also pretty high in the list. These functions start nested event loops, so the hangs we are reporting in these cases are false positives.
Comment on attachment 9029948 [details] [diff] [review]
Call BackgroundHangMonitor().NotifyWait()

Review of attachment 9029948 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #9029948 - Flags: review?(dothayer) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7d7dcdb4e3
Call BackgroundHangMonitor().NotifyWait() before opening system modal dialogs (file picker, print dialog) on Windows, r=dthayer.
https://hg.mozilla.org/mozilla-central/rev/aa7d7dcdb4e3
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

nsFilePicker::ShowFilePicker is still the most frequent hang; is there something we can do about it?

Flags: needinfo?(dothayer)
You need to log in before you can comment on or make changes to this bug.