Closed Bug 1512621 Opened 11 months ago Closed 9 months ago

"Navigated to" should not have a border if it's the first message in the output

Categories

(DevTools :: Console, defect, P3)

65 Branch
defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: nchevobbe, Assigned: lloanalas, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

**Steps to reproduce**
1. Open `data:text/html,<meta charset=utf8>`
2. Open the console
3. Check the "Persist logs" checkbox
4. Reload the page


**Expected results**

A "Navigated to data:text/html,<meta charset=utf8>" message is displayed, and looks fine

**Actual results**

The message is displayed, but it looks a bit weird because the top border of it is directly below the filter bar bottom border, which make it look like a double-border.

---

This can be fixed by adding something similar to this: 

```
.webconsole-output :first-child.message.navigationMarker {
    border-top: none;
}
```

just below https://searchfox.org/mozilla-central/rev/adec563403271e78d1a057259b3e17fe557dfd91/devtools/client/themes/webconsole.css#103-106 .
Hello Nicholas, I'm working on this bug, if you don't mind. Thanks.
Flags: needinfo?(nchevobbe)
Sure, I assigned the bug to you
Assignee: nobody → ollasmyke
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)
If it's your first bug, you might want to read this https://docs.firefox-dev.tools/getting-started/ to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :) 
Also, you can come and chat on our Slack https://devtools-html-slack.herokuapp.com/

Hello Michael,

Sorry I didn't check-in with you sooner.
Is there anything blocking you on this bug? Can I help you in some way?
Let me know if you don't have the time to work on that (that's totally cool!), I'll unassign you so someone else can give this a shot :)

Cheers!

Flags: needinfo?(ollasmyke)

Clearing the assignee field as it's been a while.
If anyone want to work on this bug, feel free to ask in a comment :)

Assignee: ollasmyke → nobody
Status: ASSIGNED → NEW

Hi Nicolas,

I'm an outreachy applicant, could this bug be assigned to me? Thanks!

I think I'm getting the hang of this!

PS: Thanks for the help on Slack!

Hello lloanalas, thanks for helping us!
I assigned the bug to you, don't hesitate to ask any questions, either here or on Slack :)

Assignee: nobody → lloanalas
Status: NEW → ASSIGNED
Flags: needinfo?(ollasmyke)
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ce57ecce474
Navigated to text in console should not have a border if it's the first message in the output. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.