1512633 - archivescraper misses ESR builds

Status: RESOLVED FIXED

(Socorro :: General, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

There's some code in archivescraper that reduces how much work it does in a given run. It looks at the most recent version, subtracts 3, and looks at builds for that and later.

Right now, we've got 65 in nightly, 64 is in beta but about to get released, and so archivescraper is looking at 62+. However, they're doing 60.0.4 ESR rc builds and those aren't getting picked up because 60 is before 62.

One possibility is to change it from "subtract 3" to "subtract N" for a more appropriate N. Another possibility is to special case "ESR" and look at "subtract 3" and also the last ESR.

This bug covers fixing this situation.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to fix today.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think I'm going to tweak the code to do "subtract N" and also add a line "and get all the ESRs" for now. ESRs live for like 10 versions, so it needs an exception. That seems the least invasive.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/3eb06c3b849686b4eb425cd67c2237c61836a86f
fix bug 1512633: fix archivescraper to pick up esr builds

This fixes archivescraper to pick up ESR builds which it was missing because of
the "only get max_version - 3 and up" optimization.

https://github.com/mozilla-services/socorro/commit/254e0a23388689673f68de1759126a68546fa905
Merge pull request #4737 from willkg/1512633-esr

fix bug 1512633: fix archivescraper to pick up esr builds

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4737: fix bug 1512633: fix archivescraper to pick up esr builds