1512656 - Selecting a failed job in a collapsed job group unexpectedly expands the group

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect)

Description

[Jonathan Kew [:jfkthame]]

I think this is a relatively recent change; maybe I'd eventually get used to it but at the moment I'm finding it really disconcerting.

Start with the default view of a push, where groups of jobs (M, X, M-e10s, etc) are collapsed and show only failures as individual jobs; passing jobs are collapsed to a single green "+N":

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e735e7e93fd1c69b8f2aacb9a431ca219fa4383b

Now, I'll often want to look at a particular failure, so I click on the job; let's say the orange BC4 in the M-e10s group. I expect that job to be highlighted, and its details shown in the bottom panels. What I don't expect is the whole M-e10s group to suddenly be expanded, so that its 30-ish passing jobs are now individually listed, and the orange BC4 that I clicked has jumped away from under the mouse cursor.

If I want to expand the group and see all the green jobs listed, I'll do that manually; I don't think this should be forced on me every time I want to inspect an individual failure. Could this behavior be reconsidered, please?

Comment 1

[Ed Morley [:emorley]]

Cameron, do you know when this might have changed? Was it intentional? :-)

Comment 2

[Cameron Dawson [:camd]]

This is a side-effect of something that was intentional.  ;)  The purpose of this was when we load a page with the URL ``selectedJob`` param, it looks for the job to select.  But the job might be in a group count that is collapsed, so we expand that group as needed.  But we now expand the group if ANY job in that group gets selected, including ones that are not collapsed into a count.  So... that's wrong.  :)  I'll fix it.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4385

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/aad088bfd74825275b15f5296cb90bfea8625302
Bug 1512656 - Fix unexpected group count expansion (#4385)