Closed Bug 1512668 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14414 - [ScrollTimeline] Upstream writing-mode currentTime tests to WPT

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14414 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14414
Details from upstream follow.

Stephen McGruer <smcgruer@chromium.org> wrote:
>  [ScrollTimeline] Upstream writing-mode currentTime tests to WPT
>  
>  This CL upstreams the writing-mode related currentTime tests to WPT.
>  There are a few mostly non-behavioral changes to the tests in this CL:
>  
>    * Some comments were edited for clarity.
>    * For tests with more than one assert_equals(), descriptions were
>      added to the asserts. This is to help locate failing assert_equal
>      lines, as jsharness does not print out the line number of a failure.
>    * In a few places we had more than one assert_equals for the same
>      scenario (e.g. multiple cases where scroll was after the
>      startScrollOffset point). These have been deduplicated.
>  
>  Bug: 911254
>  
>  Change-Id: I5e814acea281e2587164de634da9a5415b53de2c
>  Reviewed-on: https://chromium-review.googlesource.com/1366263
>  WPT-Export-Revision: 9e3c72b8869bc61a63be5623681dab96e83d6874
PR 14414 applied with additional changes from upstream: 008bfc93426ab6973a843cc201f347b90ae3028f
Ran 2 tests and 12 subtests
OK     : 2
FAIL   : 12

New tests that have failures or other problems:
/scroll-animations/current-time-writing-modes.html
    currentTime handles direction: rtl correctly: FAIL
    currentTime handles endScrollOffset with direction: rtl correctly: FAIL
    currentTime handles startScrollOffset with direction: rtl correctly: FAIL
    currentTime handles writing-mode: vertical-lr correctly: FAIL
    currentTime handles writing-mode: vertical-rl correctly: FAIL
/scroll-animations/current-time.html
    currentTime adjusts correctly for the timeRange: FAIL
    currentTime calculates the correct time based on scrolled amount: FAIL
    currentTime handles endScrollOffset correctly: FAIL
    currentTime handles startScrollOffset == endScrollOffset correctly: FAIL
    currentTime handles startScrollOffset > endScrollOffset correctly: FAIL
    currentTime handles startScrollOffset and endScrollOffset together correctly: FAIL
    currentTime handles startScrollOffset correctly: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e64567667f1
[wpt PR 14414] - [ScrollTimeline] Upstream writing-mode currentTime tests to WPT, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/db608d7c32d5
[wpt PR 14414] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/7e64567667f1
https://hg.mozilla.org/mozilla-central/rev/db608d7c32d5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.