1512686 - [mozdevice] Use pidof to test for process existence / get pid

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P1)

Comment 1

[Geoff Brown [:gbrown]]

Seems like it would be much more efficient than parsing ps output, when available.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: use 'adb shell pidof <package>' to determine process existence, where available

In my testing, pidof is not available on the 4.3 emulator, but is available on all of our newer android versions.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=20c4becb37e5999405bb11fcd885c8008cbaa122

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 9030051 [details] [diff] [review]
use 'adb shell pidof <package>' to determine process existence, where available

Review of attachment 9030051 [details] [diff] [review]:
-----------------------------------------------------------------

I like the use of pidof. Didn't know about it!

What would you think of adding a helper method pidof that is basically the meat of your addition to pkill and then calling that in both places?

::: testing/mozbase/mozdevice/mozdevice/adb.py
@@ +2437,5 @@
> +                pid_output = self.shell_output('pidof %s' % app, timeout=timeout)
> +            except ADBError:
> +                return False
> +            re_pid = re.compile(r'^[0-9]+$')
> +            match = re_pid.search(pid_output)

Won't this only match a single process id? If pidof returns more than one process id, won't this fail since it is anchored at the start and end?

Comment 4

[Geoff Brown [:gbrown]]

Attachment: use 'adb shell pidof <package>' to determine process existence, where available

Good idea - thanks.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=5c0291909b1e49ceaec04a5cbdc62d5770724100

Comment 5

[Bob Clary [:bc] (inactive)]

Comment on attachment 9030599 [details] [diff] [review]
use 'adb shell pidof <package>' to determine process existence, where available

Review of attachment 9030599 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e977d545d16a
Use pidof to determine android process pid, when available; r=bc

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e977d545d16a