1512699 - Full installer support for AArch64

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P1)

Description

[Molly Howell (she/her) (no longer active)]

Currently the full installer when run on an AArch64 machine seems to be aware that it's a 64-bit build, but doesn't properly detect what the OS architecture is, so you get the unsupported platform dialog. We need to implement the proper platform check and then ensure that we're not running up against whatever WoW redirection is in effect on this platform.

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: arm-target.installer.exe-error.png

Comment 2

[Molly Howell (she/her) (no longer active)]

Thanks, Rob. As I suspected, that's the unsupported OS dialog that comes out of our NSIS code at [0]. It seems the ${RunningX64} macro calls IsWow64Process, which never returns true on AArch64.

[0] https://searchfox.org/mozilla-central/rev/ff46b36ac2ebb243ec95fdab01340391963d62e5/browser/installer/windows/nsis/installer.nsi#1553-1560

Comment 3

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1512699 - Detect the AArch64 platform in the full installer. r=agashlin

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1512699: [win64-aarch64] Publish win64-aarch64 installer r?aki

Comment 5

[Molly Howell (she/her) (no longer active)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85de460c5c730b753f3f1ea711712b9d4c6efab9

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1afa60c35b5a
Detect the AArch64 platform in the full installer. r=agashlin

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1afa60c35b5a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8d73c84dc93
[win64-aarch64] Publish win64-aarch64 installer r=aki

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c8d73c84dc93