Closed Bug 1512790 Opened 2 years ago Closed 2 years ago
Weird border using Aero on Windows 7
74.54 KB, image/png
34.14 KB, image/png
1.23 KB, patch
|Details | Diff | Splinter Review|
1.25 KB, patch
|Details | Diff | Splinter Review|
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 Steps to reproduce: Updated to 60.3.3 Actual results: Although first tab is no better aligned with the toolbar beneath it, there is no a weird transparent border going at the top of the window, when in 60.3.1 whole top of the window used same color. It looks jarring. Although Thunderbird never used my Aero setting correctly (no transparent gray color), but at least it was using solid color throughout the top of the window and looked similar to my other windows. This is not happening in maximized mode. Expected results: It should go back to previous usage of the same solid color throughout the top of the window or drop that bluish background color and use Aero setting like Firefox or other applications in Windows 7. It seems like small border is currently using Aero color, but tabbar has that background.
The multiple backgrounds bug regressed the position of the navigation-toolbox on Win7. Moving the tabs-toolbar 4px up fixes this. I can't say why this happens only on Win7 but it must be because of the use of position: relative;.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9030888 - Flags: review?(jorgk)
Is this a continuation of bug 1510913? On 2nd Dec 2018 you sent me a screenshot of the misaligned tab. Now the alignment is right, but something else is wrong. Can you please attach a screenshot with and without the patch.
(In reply to Jorg K (GMT+1) from comment #2) > Is this a continuation of bug 1510913? On 2nd Dec 2018 you sent me a > screenshot of the misaligned tab. Now the alignment is right, but something > else is wrong. Can you please attach a screenshot with and without the patch. No, it has nothing to do with bug 1510913. On the screenshot I've sent you was the fog already shifted to the bottom. The attached screenshot shows on top before the patch and on bottom with the patch. Under Win 7 the tabs don't touch the top border. FX is the same.
Comment on attachment 9030888 [details] [diff] [review] 1512790-move-navigation-toolbox.patch Thanks for the screenshot. I assume that we'll backport this.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/fd0c6e10a3ab move the #navigation-toolbox 4px up on Windows 7. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Sorry, I had to back this out: https://hg.mozilla.org/comm-central/rev/cf2b7590721a5a0518feedb0b44f29ee25cc1417 Backed out changeset fd0c6e10a3ab (bug 1512790) for causing test failures on Windows 7. a=backout DONTBUILD This is the test failure: SUMMARY-UNEXPECTED-FAIL | Z:\task_1544742928\build\tests\mozmill\folder-display\test-opening-messages.js | test-opening-messages.js::test_open_message_in_new_window EXCEPTION: messenger window height not equal to the sum of children heights: "stringbundleset": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "": 0, "mailCommands": 0, "mailKeys": 0, "mainPopupSet": 0, "editContactPanel": 0, "LW-background-box": 0, "navigation-toolbox": 20, "mail-toolbox": 35, "aHTMLTooltip": 0, "messagepaneboxwrapper": 913, "customizeToolbarSheetPopup": 0, "status-bar": 22, : '986' != '990'.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Thanks for backing-out the patch. It was the wrong attempt. Here the correct one for c-c and beta: The additional padding introduced in bug 1496752 isn't needed. It lead me also to a wrong fix for the Aero fog. Now we know where the 4px came from. :-( The Aero fog fix follows in the next patch.
Moving the Aero fog from the tabs-toolbar to the navigation-toolbox fixes the issue. This was my first solution. But the 4px gap lead me to the wrong solution. Now, back to my first solution. Sorry for the wasted time. I started a try based on the esr branch, https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=80acda5ab5a92f01d4606cf09f16aef31735868b . I'll try it on my Win7 Aero VM when it's finished.
Comment on attachment 9031367 [details] [diff] [review] 1512790-remove-tabs-toolbar-padding.patch I can't test that, so rs=jorgk. This needs to go to the ESR, right?
(In reply to Jorg K (GMT+1) from comment #9) > Comment on attachment 9031367 [details] [diff] [review] > 1512790-remove-tabs-toolbar-padding.patch > > I can't test that, so rs=jorgk. This needs to go to the ESR, right? No, not to ESR. The affecting patch from bug 1496752 didn't land on ESR. A Linux only patch landed on ESR. I can't remove the approval-comm-esr60 flag.
Comment on attachment 9031367 [details] [diff] [review] 1512790-remove-tabs-toolbar-padding.patch Sorry, didn't read. This is for trunk and beta.
Comment on attachment 9031370 [details] [diff] [review] 1512790-move-fog.patch So these changes are in @media (-moz-windows-glass). I can't test that. rs=jorgk.
Tested the try build on Win7 Aero and the fog has no gap on top.
Pushed by email@example.com: https://hg.mozilla.org/comm-central/rev/1366f6160d3c Remove unneeded extra padding introduced with bug 1496752. r=jorgk https://hg.mozilla.org/comm-central/rev/8fe538ef7de1 Move the Win7 Aero fog from tabs-toolbar to navigation-toolbox. r=jorgk
Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.