1512808 - filter rule date format broken

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[:aceman]

It seems the recent changes to date formatting according to locale has broken our display of dates in filter rules.

When editing a filter, select Date as a term in filter criteria. Notice the sample date showing in the value field.

It shows 8.2018.12 (8th Dec 2018) for me, which is complete nonsense for either en_US or sk_SK locale that come into play in my TB environment.

Comment 1

[:aceman]

Attachment: 1512808.patch

Using Services.intl.DateTimeFormat() in initLocaleShortDateFormat() may return strings with spaces, which we didn't expect. E.g. in may case it was "8. 12. 2018".

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9030089 [details] [diff] [review]
1512808.patch

Review of attachment 9030089 [details] [diff] [review]:
-----------------------------------------------------------------

Can we make this two patches, please, the clean-up should go separate. I can't see the forest for the trees.

::: mailnews/base/content/dateFormat.js
@@ +24,5 @@
>    try {
>      const dateFormatter = new Services.intl.DateTimeFormat(undefined,
>        { dateStyle: "short" });
>      var aDate = new Date(1999, 11, 1);
> +    var dateString = dateFormatter.format(aDate).replace(/ /g,"");

This is the net change, the rest is boy-scout clean-up which obscures it.

@@ +34,2 @@
>      {
> +      arrayOfStrings = dateString.split( possibleSeparators[i]);

Another space after the (.

Comment 3

[:aceman]

Attachment: 1512808.patch v2

Yes, thanks.

Comment 4

[:aceman]

Affects multiple locales now containing spaces, e.g. "sk", "cs", "hr", "hu".
Others like "en", "fr", "es", "ru" are OK.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3afcea69ad2
fix date format detection in initLocaleShortDateFormat(). r=jorgk DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9030111 [details] [diff] [review]
1512808.patch v2

I assume that's a problem in TB 60 as well.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 60.4 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/321076459c7e7d81d4fdcff7284ebcc0fc53e272

Comment 8

[:aceman]

No, it does not happen on TB60 on the same machine. But it shouldn't hurt if you land it there too.

Comment 9

[:aceman]

Ok, the 2 versions of TB run under different users, there may be different settings of the desktop environment, if that is taken into account in any way.

Comment 10

[:aceman]

Right, it does happen in TB60 under the same user as trunk.

Comment 11

[Jorg K (CEST = GMT+2)]

Thanks for confirming, I've already landed it on the ESR release ;-)