Closed Bug 1512822 Opened Last year Closed 11 months ago

Use clang-cl for aarch64-windows builds

Categories

(Firefox Build System :: Toolchains, enhancement)

enhancement
Not set

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(2 files)

clang-cl support for aarch64-windows is mostly complete but is missing SEH support: https://reviews.llvm.org/D53540

Once SEH lands we should be able to switch those builds to clang-cl, which will let us drop support for MSVC project-wide.
Actually, it seems like SEH missing would be blocking for _shipping_ those builds, but can't we already build them without SEH?
(In reply to Mike Hommey [:glandium] from comment #1)
> Actually, it seems like SEH missing would be blocking for _shipping_ those
> builds, but can't we already build them without SEH?

I've done builds like this locally, but I feel uncomfortable about landing that in the tree. We risk ending up in a bad spot if MSVC becomes unbuildable, clang-cl builds are unshippable, and the SEH developer gets pulled away to other priorities.
This will likely be subsumed by bug 1512921, but just to call it out explicitly: we'll want to pick up the patch for https://bugs.llvm.org/show_bug.cgi?id=39667 which fixes a quadratic-time issue in lld on this platform.
Depends on: 1514592
Blocks: 1515699
Depends on: 1517586
Depends on: 1517594
Depends on: 1520014
Depends on: 1520021
Depends on: 1520880
Depends on: 1521129
Assignee: nobody → dmajor
Blocks: 1522289
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0082435be9f2
Use clang-cl rather than MSVC for aarch64 builds r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/fdceb5ba6e8c
Remove "MSVC" from the name of AArch64 builds r=tomprince
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
No longer depends on: 1522771

This broke l10n. As in, there aren't any l10n aarch64 builds anymore.

You need to log in before you can comment on or make changes to this bug.