Closed
Bug 1512842
Opened 5 years ago
Closed 5 years ago
--in-content-button-background-active should be --gray-90-a30 instead of --gray-30
Categories
(Toolkit :: Themes, defect, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: ntim, Assigned: Kammueller)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Updated•5 years ago
|
Priority: -- → P5
Updated•5 years ago
|
Priority: P5 → P3
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → matthias
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d3d07f0155a Adjusted Button Background colour according to photon spec. r=ntim,dao
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d3d07f0155a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•5 years ago
|
status-firefox65:
--- → affected
Reporter | ||
Comment 4•5 years ago
|
||
Comment on attachment 9030358 [details] Bug 1512842 - Adjusted Button Background colour according to photon spec. r=ntim [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1511394 User impact if declined: Button active background does not match the spec Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): One line CSS change String changes made/needed:
Attachment #9030358 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9030358 [details] Bug 1512842 - Adjusted Button Background colour according to photon spec. r=ntim [Triage Comment] Minor CSS tweak, approved for 65.0b5.
Attachment #9030358 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/ca8fd2a3447a
Updated•5 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•