Closed Bug 1512856 Opened 7 years ago Closed 6 years ago

Intermittent browser/base/content/test/performance/browser_tabswitch.js | unexpected changed rect: ({x1:417, x2:472, y1:0, y2:32, w:56, h:33}), window width: 1280 -

Categories

(Firefox :: General, defect, P5)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1455054

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure)

Filed by: cbrindusan [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=216095204&repo=autoland https://queue.taskcluster.net/v1/task/QOciwPGxRXGJasjLOqrcDQ/runs/0/artifacts/public/logs/live_backing.log [task 2018-12-09T05:58:26.362Z] 05:58:26 INFO - TEST-START | browser/base/content/test/performance/browser_tabswitch.js [task 2018-12-09T05:58:26.476Z] 05:58:26 INFO - GECKO(2198) | ++DOCSHELL 0xe7457800 == 3 [pid = 2338] [id = {25887c3d-2366-488d-81c1-c4ccb82be817}] [task 2018-12-09T05:58:26.478Z] 05:58:26 INFO - GECKO(2198) | ++DOMWINDOW == 8 (0xe7479080) [pid = 2338] [serial = 42] [outer = (nil)] [task 2018-12-09T05:58:26.537Z] 05:58:26 INFO - GECKO(2198) | ++DOMWINDOW == 9 (0xe7458c00) [pid = 2338] [serial = 43] [outer = 0xe7479080] [task 2018-12-09T05:58:26.553Z] 05:58:26 INFO - GECKO(2198) | [Child 2338, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 8166 [task 2018-12-09T05:58:26.581Z] 05:58:26 INFO - GECKO(2198) | ++DOMWINDOW == 10 (0xe7459c00) [pid = 2338] [serial = 44] [outer = 0xe7479080] [task 2018-12-09T05:58:26.597Z] 05:58:26 INFO - GECKO(2198) | [Child 2338, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 8166 [task 2018-12-09T05:58:26.815Z] 05:58:26 INFO - GECKO(2198) | [Parent 2198, Main Thread] WARNING: Remote iframe not rendered: file /builds/worker/workspace/build/src/layout/ipc/RenderFrame.cpp, line 271 [task 2018-12-09T05:58:26.873Z] 05:58:26 INFO - GECKO(2198) | [Parent 2198, Main Thread] WARNING: Remote iframe not rendered: file /builds/worker/workspace/build/src/layout/ipc/RenderFrame.cpp, line 271 [task 2018-12-09T05:58:27.010Z] 05:58:27 INFO - GECKO(2198) | [Parent 2198, Main Thread] WARNING: Remote iframe not rendered: file /builds/worker/workspace/build/src/layout/ipc/RenderFrame.cpp, line 271 [task 2018-12-09T05:58:27.092Z] 05:58:27 INFO - GECKO(2198) | [Parent 2198, Main Thread] WARNING: Remote iframe not rendered: file /builds/worker/workspace/build/src/layout/ipc/RenderFrame.cpp, line 271 [task 2018-12-09T05:58:27.161Z] 05:58:27 INFO - GECKO(2198) | [Parent 2198, Main Thread] WARNING: Remote iframe not rendered: file /builds/worker/workspace/build/src/layout/ipc/RenderFrame.cpp, line 271 [task 2018-12-09T05:58:27.223Z] 05:58:27 INFO - GECKO(2198) | [Parent 2198, Main Thread] WARNING: Remote iframe not rendered: file /builds/worker/workspace/build/src/layout/ipc/RenderFrame.cpp, line 271 [task 2018-12-09T05:58:27.441Z] 05:58:27 INFO - GECKO(2198) | --DOCSHELL 0xe7456400 == 3 [pid = 2281] [id = {c0dcadf4-067c-49f5-86f2-f2ad64087f44}] [task 2018-12-09T05:58:27.466Z] 05:58:27 INFO - TEST-INFO | started process screentopng [task 2018-12-09T05:58:28.097Z] 05:58:28 INFO - TEST-INFO | screentopng: exit 0 [task 2018-12-09T05:58:28.099Z] 05:58:28 INFO - Buffered messages logged at 05:58:26 [task 2018-12-09T05:58:28.101Z] 05:58:28 INFO - Entering test bound [task 2018-12-09T05:58:28.103Z] 05:58:28 INFO - TEST-PASS | browser/base/content/test/performance/browser_tabswitch.js | We shouldn't have added any new expected reflows. - 0 == 0 - [task 2018-12-09T05:58:28.106Z] 05:58:28 INFO - Buffered messages logged at 05:58:27 [task 2018-12-09T05:58:28.108Z] 05:58:28 INFO - TEST-PASS | browser/base/content/test/performance/browser_tabswitch.js | 0 unexpected reflows - true == true - [task 2018-12-09T05:58:28.110Z] 05:58:28 INFO - comparing 3 frames [task 2018-12-09T05:58:28.114Z] 05:58:28 INFO - Buffered messages finished [task 2018-12-09T05:58:28.116Z] 05:58:28 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_tabswitch.js | unexpected changed rect: ({x1:417, x2:472, y1:0, y2:32, w:56, h:33}), window width: 1280 -
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

:florian, we have 15 open bugs against this testcase:
https://bugzilla.mozilla.org/buglist.cgi?quicksearch=browser_tabswitch.js&list_id=14525157

could we make this a single bug, or does it make sense to unique bugs for the different values in the rect.

Flags: needinfo?(florian)

(In reply to Narcis Beleuzu [:NarcisB] from comment #3)

Fail reappeared on autoland.
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221816991&repo=autoland&lineNumber=5692

This is showing the second tab that's still animating. I don't expect that within a tab switch test.

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #5)

:florian, we have 15 open bugs against this testcase:
https://bugzilla.mozilla.org/buglist.cgi?quicksearch=browser_tabswitch.js&list_id=14525157

could we make this a single bug, or does it make sense to unique bugs for the different values in the rect.

Bug 1455054 is a different issue.
Bug 1465574 is similar to bug 1502255.

All the other bugs with rects of height 33px or 10x10px or 14x14px rects look like the second tab is still animating when we attempt to begin the tabswitch test.
I think at https://searchfox.org/mozilla-central/rev/c035ee7d3a5cd6913e7143e1bce549ffb4a566ff/browser/base/content/test/performance/browser_tabswitch.js#37 we should either do something to skip the animation, or await something to ensure the animation is finished before proceeding.

Felipe, do you have a recommendation? Is this a regression from your recent tab animation work, or was this before your work landed? This bug was filed 2 months, but the failures in all the other similar bugs seem to have spiked this week.

Flags: needinfo?(florian) → needinfo?(felipc)

Not a regression from my work because it got backed out.

Since this is a reflow test, I don't think we should skip the animation. We can just wait for the transitionend event, like other tests do. e.g.: https://searchfox.org/mozilla-central/rev/465dbfe030dfec7756b9b523029e90d48dd5ecce/browser/base/content/test/performance/browser_tabclose.js#39-40

Once the groundwork for the new tab animations land again, I'll be replacing these listeners for transitionend to listeners for a new event, TabAnimationEnd

Flags: needinfo?(felipc)
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.