Closed
Bug 1512951
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14436 - Don't estimate the top of bottom-aligned OOFs as bottom.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14436 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14436 Details from upstream follow. Morten Stenshorne <mstensho@chromium.org> wrote: > Don't estimate the top of bottom-aligned OOFs as bottom. > > (This is a reland of > https://chromium-review.googlesource.com/c/chromium/src/+/1355920 with > proper rebaselining) > > We'll incorrectly think that we get fragmented in that case, which will > lead to incorrect height, which will lead to incorrect top offset, > which will lead to incorrect fragmentation. > > This has probably been the cause for a flaky web test, that behaved > even worse in LayoutNG, because in NG we force legacy layout as soon as > fragmentation is involved (so when entering printing, we typically need > to rebuild the entire layout object tree, with no former height to base > the bottom estimate on (which is what saved us when NG is disabled - > ehm, at least most of the time)). > > TBR=atotic@chromium.org,eae@chromium.org > Bug: 910300 > Change-Id: I00bce89900c50d6db9b39a4b72dbd6ab653184a7 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > > Reviewed-on: https://chromium-review.googlesource.com/1365436 > WPT-Export-Revision: d26925da7fbd89df505218edb434a85e6c46b3e2
Assignee | ||
Updated•5 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=581daeb29a5ab44e0fe5d75a45ac426e8e3c40b1
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=457fc555c109bb3b210e2f5bc2991659bee28704
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2a05b30e5089da6f047acfc2ce8836bd93d7b1e
Assignee | ||
Comment 4•5 years ago
|
||
Ran 2 tests and 3 subtests OK : 1 PASS : 3 FAIL : 1 New tests that have failures or other problems: /css/css-break/block-end-aligned-abspos-with-overflow.html: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9014ced854ca [wpt PR 14436] - Don't estimate the top of bottom-aligned OOFs as bottom., a=testonly
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9014ced854ca
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•