Closed
Bug 1512969
Opened 6 years ago
Closed 6 years ago
Add assertions about cross compartment marking
Categories
(Core :: JavaScript: GC, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
2.16 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
When we calculate the sweep groups we arrange things so that a cross compartment pointer to an unmarked cell in a different zone ensures that the target zone is not swept before the source zone (otherwise we may free a reachable thing before it has been marked).
This patch adds assertions to the marking code that we never encounter a cross compartment pointer to something that hasn't been marked in a sweeping zone.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9030223 -
Flags: review?(sphink)
|
||
Updated•6 years ago
|
Attachment #9030223 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e8ec8556200
Add cross-compartment marking assertion to catch errors in sweep groups calculation r=sfink
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•