Closed Bug 1512978 Opened 7 years ago Closed 4 years ago

Amazon search shortcut does not exist for en-CA

Categories

(Firefox :: New Tab Page, defect, P3)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: nanj, Unassigned)

Details

This is reproducible on Windows/Linux/OS X Nightly version: 65.0a1 (2018-12-10) (64-bit) After clicking on the Amazon search shortcut, it focused the cursor in the Awesome Bar with the `@amazon` prefix. Then typed in any search keywords and entered, it committed a search using the default search engine with search keywords "@amazon xyz". Expected: it should search with the provided keywords at "amazon.com".
Perhaps it was due to my geo (Canada). @amazon wasn't even highlighted in my Awesome Bar, nor could I find the amazon search shortcut in the "Add search engine" panel. Although, I do have "amazon.ca" in my search engine list.
Are you using en-CA? That should be using amazon-ca search plugin, and that does not get an internal keyword/alias set: https://searchfox.org/mozilla-central/rev/fd62b95c187a40b328d9e7fd9d848833a6942b57/toolkit/components/search/nsSearchService.js#916-930 https://searchfox.org/mozilla-central/rev/fd62b95c187a40b328d9e7fd9d848833a6942b57/browser/components/search/searchplugins/list.json#233-236 Not sure if this is intended or not.
Summary: Amazon search shortcut is broken in nightly → Amazon search shortcut does not exist for en-CA
It wasn't intended. I added new locale specific Amazon engines, we need to add them to this list (or just use amazon)
Assignee: nobody → mozilla
(In reply to Ed Lee :Mardak from comment #2) > Are you using en-CA? That should be using amazon-ca search plugin, and that > does not get an internal keyword/alias set: My locale is en-US. If geo/locale caused this, we might want to change the icon in the Topsites. The magnifying glass was still attached to the Amazon icon, which was confusing in this case.
At run time, we detect you are in Canada and switch the engine to Canada. So that would be why you see this.
Priority: -- → P3
Component: Activity Streams: Newtab → New Tab Page
Assignee: mozilla → nobody

This works fine now after Search Mode implementation and Amazon reconfiguration, so I'm closing as RWFM.
Please reopen in case it reoccurs.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.