1512980 - Contrast ratio indicator is not working in iframes.

Status: VERIFIED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Contrast ratio indicator shows up as "Unable to calculate" when trying to hover over text in iframes because the styling applied for contrast calculations is applied on the root window instead of the window that the node belongs to.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1512980 - ensure that the right window is used when calculating the contrast ratio in accessibility highlighter. r=pbro

MozReview-Commit-ID: 9AFXlLnkZvs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/883d0ac7c183
ensure that the right window is used when calculating the contrast ratio in accessibility highlighter. r=pbro

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9030233 [details]
Bug 1512980 - ensure that the right window is used when calculating the contrast ratio in accessibility highlighter. r=pbro

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1505848

User impact if declined: Users will not be able to use highlighter's colour contrast indicator in iframes. In cases like that it will display: Unable to calculate.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Simply updating which window is used to apply styles that are needed to calculate colour contrast.

String changes made/needed: None

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/883d0ac7c183

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030233 [details]
Bug 1512980 - ensure that the right window is used when calculating the contrast ratio in accessibility highlighter. r=pbro

[Triage Comment]
Fixes users being unable to use the color contrast indicator in iframes. Approved for 64.0b4.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a4803c65849c

Comment 7

[Catalin Sasca, Desktop QA [:csasca]]

I successfully reproduced the issue on Firefox Nightly 65.0a1 (2018-12-09) under Ubuntu 18.04 (x64) with some help from Yura.
The issue is not reproducible anymore on latest Firefox Beta 65.0b4 and latest Nightly 66.0a1 (2018-12-12). Tests were performed under Ubuntu 18.04 (x64), Windows 10 (x64) and macOS 10.11.