1513021 - Enable the storage access API on desktop

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P1)

Description

[(no longer active)]

(An intent to ship email needs to be sent for this.  We intend to enable this to ride the trains for 65.)

Comment 1

[(no longer active)]

Attachment: Bug 1513021 - Ship the Storage Access API on all desktop platforms;

Comment 2

[(no longer active)]

Comment on attachment 9032298 [details]
Bug 1513021 - Ship the Storage Access API on all desktop platforms;

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Not a regression

User impact if declined: We'd like to ship this API in 65, please see the intent to ship thread for rationale: https://groups.google.com/forum/#!topic/mozilla.dev.platform/BZ36ZDV0Fik

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This has been turned on in Nightly for a few cycles.  The API itself will not do anything unless the default cookie restrictions feature (bug 1473978) is shipped, and it isn't yet known to be used by a lot of third-party trackers, so we expect the risk of shipping this API at this point to be minimal.

String changes made/needed: None

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dc724f82cb1
Ship the Storage Access API on all desktop platforms; r=baku

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2dc724f82cb1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9032298 [details]
Bug 1513021 - Ship the Storage Access API on all desktop platforms;

[Triage Comment]
Already enabled on Nightly for a few cycles and doesn't do much by itself unless the default cookie restrictions are also enabled (which is not yet the case). Approved for 65.0b7 so as to not block any future decisions around this feature as we move forward.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is there anything QA can/should be doing with this for now to be on the lookout for any regressions or functional issues?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2927c965fcf9

Comment 8

[(no longer active)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> Is there anything QA can/should be doing with this for now to be on the
> lookout for any regressions or functional issues?

No specific QA needed here, this feature has been receiving QA on the Nightly train.  (And yes, we should of course be watching for regressions.)

Comment 9

[Chris Mills [:cmills]]

I've documented this:

Removed it from experimental features pages now it is enabled in desktop:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features

Removed experimental banners from pages as it is now available in two browsers by default:
https://developer.mozilla.org/en-US/docs/Web/API/Document
https://developer.mozilla.org/en-US/docs/Web/API/Document/hasStorageAccess
https://developer.mozilla.org/en-US/docs/Web/API/Document/requestStorageAccess

Updated the browser compat data:
https://github.com/mdn/browser-compat-data/pull/3303

Let me know if this looks OK. Thanks!

Comment 10

[(no longer active)]

Thanks, looks great!