Crash in mozilla::gfx::VRProcessParent::Shutdown

RESOLVED FIXED in Firefox 65

Status

()

--
critical
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: darkspirit, Assigned: daoshengmu)

Tracking

(Blocks: 1 bug, {crash, nightly-community})

Trunk
mozilla66
Unspecified
Linux
crash, nightly-community
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 fixed, firefox66 fixed)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
Debian Testing, gfx.webrender.all;true, layers.gpu-process.enabled;true, dom.vr.process.enabled;true

By opening https://bug1513017.bmoattachments.org/attachment.cgi?id=9030280 WebRender (the GPU process) crashed, but it seems something VR-related would have crashed as well. Might it be related to bug 1512429?

bp-7c6fd4df-b8fe-432d-a15c-86b420181210 [@ webrender::frame_builder::FrameBuilder::build ]
bp-f8f0214b-62b7-4636-b751-74a390181210 [@ webrender::frame_builder::FrameBuilder::build ]
bp-6c0acfec-8d43-42fe-ad92-c572a0181210 [@ mozilla::gfx::VRProcessParent::Shutdown ]


This bug was filed from the Socorro interface and is
report bp-6c0acfec-8d43-42fe-ad92-c572a0181210.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::gfx::VRProcessParent::Shutdown mfbt/UniquePtr.h:308
1 libxul.so mozilla::gfx::VRProcessManager::OnXPCOMShutdown gfx/vr/ipc/VRProcessManager.cpp:69
2 libxul.so mozilla::gfx::VRProcessManager::Observer::Observe gfx/vr/ipc/VRProcessManager.cpp:117
3 libxul.so nsObserverService::NotifyObservers xpcom/ds/nsObserverList.cpp:66
4 libxul.so mozilla::ShutdownXPCOM xpcom/build/XPCOMInit.cpp:851
5 libxul.so ScopedXPCOMStartup::~ScopedXPCOMStartup toolkit/xre/nsAppRunner.cpp:1323
6 libxul.so mozilla::UniquePtr<ScopedXPCOMStartup, mozilla::DefaultDelete<ScopedXPCOMStartup> >::reset mfbt/UniquePtr.h:486
7 libxul.so XREMain::XRE_main mfbt/UniquePtr.h:296
8 libxul.so XRE_main toolkit/xre/nsAppRunner.cpp:4845
9 firefox-bin do_main browser/app/nsBrowserApp.cpp:214

=============================================================
(Reporter)

Updated

3 months ago
Component: Graphics → WebVR
(Assignee)

Comment 1

3 months ago
We are not going to make dom.vr.process.enabled;true in Linux. We only wanna provide VR process in Windows.
(Reporter)

Updated

3 months ago
See Also: → bug 1515938
(Assignee)

Comment 3

3 months ago
We will hide dom.vr.process.enabled pref on other platforms to avoid to trigger unexpected behaviors.
Assignee: nobody → dmu

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3e05f334f7c2
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
status-firefox64: --- → unaffected
status-firefox65: --- → unaffected
status-firefox-esr60: --- → unaffected
(Assignee)

Comment 5

3 months ago
Comment on attachment 9032985 [details]
Bug 1513022 - Only show dom.vr.process.enabled pref in Windows.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1430038

User impact if declined: We don't expect user to enable this preference besides Windows platform, so I would like to hide this preference to avoid unexpected behavior, like crashes, at other platforms.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It only hides the preference, it will not change any functionalities.

String changes made/needed:
Attachment #9032985 - Flags: approval-mozilla-beta?
(Assignee)

Updated

3 months ago
Blocks: 1515938
Comment on attachment 9032985 [details]
Bug 1513022 - Only show dom.vr.process.enabled pref in Windows.

[Triage Comment]
Hides a preference from non-Windows users so they don't set it and start crashing. Approved for 65.0b8.
Attachment #9032985 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox65: unaffected → affected
status-firefox66: disabled → fixed

Comment 7

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/39073b9505b8
status-firefox65: affected → fixed
You need to log in before you can comment on or make changes to this bug.