Closed Bug 1513023 Opened 11 months ago Closed 11 months ago
Reloading single test quits the browser instead of rerunning it
47 bytes, text/x-phabricator-request
|Details | Review|
STEPS TO REPRODUCE: 1) Build Firefox. 2) mach wpt testing/web-platform/tests/css/selectors/attribute-selectors/attribute-case/semantics.html 3) Wait for test to finish and be sitting there showing results. 4) Edit the test file. 5) Reload the test. EXPECTED RESULTS: Reruns the test with the modified file. ACTUAL RESULTS: Quits the browser. The actual test doesn't matter much; the above is what I happened to be running today.
When wpt is used by developers they often want to reload a test that's running to allow iterative development (or running under devtools, etc.). The recent switch to target marionette commands at the test window rather than the opener window broke this as waiting is implemented as an async script that never returns (i.e. a promise that never resolves) and when this is in the test window navigating that window causes the script to return. A simple, but not particuarly elegant, solution here is to simply rerun the script in the new window.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0a36f92c457a Wait for wpt tests to finish across reloads, r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14441 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/14441 * continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/466204382?utm_source=github_status&utm_medium=notification)
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.