Closed Bug 1513029 Opened 10 months ago Closed 10 months ago

Trackers and Cookie hover state colours are unreadable in the dark theme

Categories

(Firefox :: Site Identity, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 66
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 + verified
firefox66 + verified

People

(Reporter: ehsan, Assigned: ewright)

References

Details

Attachments

(2 files)

Attached image Screenshot
See the screenshot.

Erica, do you have cycles to take this?
Flags: needinfo?
Flags: needinfo? → needinfo?(ewright)
Blocks: 1501991
Sure, on it.
Assignee: nobody → ewright
No longer blocks: 1501991
Status: NEW → ASSIGNED
Flags: needinfo?(ewright)
Blocks: 1501991
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d1d6538796dd
Trackers and Cookie hover state colours are visible in Linux dark theme. r=ntim
Please remember to ask uplift, thanks!  :-)
Comment on attachment 9030321 [details]
Bug 1513029 - Trackers and Cookie hover state colours are visible in Linux dark theme.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Trackers/Cookie subviews (landed in 65)

User impact if declined: See comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Straightforward small CSS patch

String changes made/needed: n/a
Attachment #9030321 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/d1d6538796dd
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment on attachment 9030321 [details]
Bug 1513029 - Trackers and Cookie hover state colours are visible in Linux dark theme.

[Triage Comment]
Fixes a readability issue in UI introduced in Fx65. Approved for 65.0b4.
Attachment #9030321 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Reproduced the issue on Linux 16.04 with Nightly 65.0a1 (2018-12-10).

Verified as fixed with 65.0b4 and Nightly 66.0a1 (2018-12-12) with Linux 16.04, Windows 10x64 and macOS 10.14.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.