Closed Bug 1513034 Opened 5 years ago Closed 5 years ago

Delete functions lower.py that coverage says are dead

Categories

(Core :: IPC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

Details

Attachments

(1 file)

Running the IPDL compiler, as done in a build, under coverage highlighted a fair number of dead functions, we should remove them!
Keywords: checkin-needed
Hello, 
Can you please get a reviewer to accept the current diff?
Flags: needinfo?(agaynor)
Keywords: checkin-needed
Flags: needinfo?(agaynor) → needinfo?(nika)
Flags: needinfo?(nika)
Keywords: checkin-needed
Getting this when trying to land:

Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpScTLTY\npatching file ipc/ipdl/ipdl/lower.py\nHunk #4 FAILED at 761\nHunk #6 FAILED at 1154\n2 out of 11 hunks FAILED -- saving rejects to file ipc/ipdl/ipdl/lower.py.rej\nabort: patch failed to apply', '')
Flags: needinfo?(agaynor)
Rebased on m-c, thanks!
Flags: needinfo?(agaynor)
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/1d54ba8e0ec9
delete dead code from IPDL's lower.py identified by coverage; r=nika
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1d54ba8e0ec9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: