1513035 - Text in menus is incorrectly centered.

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Erica Wright [:ewright]]

The styles that were changed to update the button spec also affected the menu inputs.

STR:
- go to about:preferences
- under "fonts and colors" click to open the menu

AR:
- each menu item is centered

ER:
- The menu items are left-aligned in LTR and right-aligned in RTL


I believe this is due to this rule https://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#177

Comment 1

[Erica Wright [:ewright]]

Attachment: Screen Shot 2018-12-10 at 2.02.46 PM.png

Comment 2

[Matthias :Kammueller]

I tested to remove the "text-align" line.
This did the trick and the buttons are still centered.

Comment 3

[Matthias :Kammueller]

Attachment: Bug 1513035 - Remove text-align: center; from common.css buttons r=ewright, dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b976d3cfa074
Remove text-align: center; from common.css buttons r=ewright,dao

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b976d3cfa074

Comment 6

[Dão Gottwald [:dao]]

This will need to be uplifted.

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 9030360 [details]
Bug 1513035 - Remove text-align: center; from common.css buttons r=ewright, dao

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1511394

User impact if declined: See comment 0 & comment 1

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: See comment 0 & comment 1

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): one line CSS removal

String changes made/needed:

Comment 8

[Catalin Sasca, Desktop Test Engineering [:csasca]]

I successfully reproduced the issue on Firefox Nightly 65.0a1 (2018-12-10) under Windows 10 (x64) using STR from Comment 0.

The issue is no longer reproducible on latest Nightly 66.0a1 (2018-12-12) under Windows 10 (x64), macOS 10.12 and Ubuntu 16.04 (x64).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030360 [details]
Bug 1513035 - Remove text-align: center; from common.css buttons r=ewright, dao

[Triage Comment]
Minor CSS tweak, approved for 65.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b5a033723f0e

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

The issue is verified fixed on Firefox 65.0b5 (20181216183345). Tests were performed under Windows 10 (x64), macOS 10.12 and Ubuntu 16.04 (x86).