1513040 - Minor ParseNode cleanups

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

Split off from bug 1512428 comment 2:

- Rename all ParseNodeKinds that are expressions
  to have names that end with Expr, and all statements to end in Stmt.
  (For now, make an exception for Function and Class, which can occur as either
  declarations or expressions.) Also Star -> MulExpr.

- In a separate changeset, change FOR_EACH_PARSE_NODE_KIND to use a class name
  (like TernaryNode) instead of an arity enum (like PN_TERNARY) as the second argument.
  Each class will have to have something like `static constexpr TernaryNode::arity()`,
  not a big deal. Then move `ParseNodeVisitor::visit_PN_TERNARY_children(ParseNode*& pn)`
  to `TernaryNode::visitChildren<V>(V&)`, and likewise for the other visit_*_children
  methods. This should make some of the `unsafe{Kid,Left,Right,Kid2,Kid3,Blah}Reference()`
  methods unnecessary.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Bug 1513040 - Rename ParseNodeKinds to end with Stmt or Expr.

Comment 2

[Ashley Hauck [:khyperia]]

Attachment: Bug 1513040 - Change FOR_EACH_PARSE_NODE_KIND to use type instead of arity.

Depends on D14321

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e69ec9477ef8
Rename ParseNodeKinds to end with Stmt or Expr. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/bab13130b3f0
Change FOR_EACH_PARSE_NODE_KIND to use type instead of arity. r=jorendorff

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e69ec9477ef8
https://hg.mozilla.org/mozilla-central/rev/bab13130b3f0

Comment 5

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1512428, Bug 1513040) for causing raptor tp6-5 perma failures on Windows 7 opt/pgo

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&searchStr=windows%2C7%2Ctp6-5&revision=bab13130b3f0880709e8c00ce77fec3ddd9eeea2&selectedJob=217671261

failure logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217662963&repo=autoland&lineNumber=1255

Comment 6

[Ashley Hauck [:khyperia]]

Quick note: The issue was in the base bug this patch is based off of ( https://bugzilla.mozilla.org/show_bug.cgi?id=1512428 ) so I'm going to land these again with the fix for the base bug. (The try run I mention in the other thread's comments includes these patches).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6356c45cfbb7
Rename ParseNodeKinds to end with Stmt or Expr. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/598f93e37949
Change FOR_EACH_PARSE_NODE_KIND to use type instead of arity. r=jorendorff

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/6356c45cfbb7
https://hg.mozilla.org/mozilla-central/rev/598f93e37949