Closed Bug 1513108 Opened Last year Closed 11 months ago

Remove the separate class extension hook for getting a weakmap key delegate

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file, 1 obsolete file)

There are no users that return anything else for a delegate.
Replace with just unwrapping the key.
Attachment #9030346 - Flags: review?(jcoppeard)
Comment on attachment 9030346 [details] [diff] [review]
Remove the separate class extension hook for getting a weakmap key delegate

Review of attachment 9030346 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for doing this.  I like how this makes our tests closer to the actual code.
Attachment #9030346 - Flags: review?(jcoppeard) → review+
Replace with just unwrapping the key, since there are no users that return anything else for a delegate.
Attachment #9030610 - Flags: review?(jcoppeard)
Attachment #9030346 - Attachment is obsolete: true
Attachment #9030610 - Flags: review?(jcoppeard) → review+
Oops. I've been fighting with the autoformatting stuff (and I think I finally won!), so accidentally re-posted this patch. Please ignore.
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0429fe76b4cc
Remove the separate class extension hook for getting a weakmap key delegate, r=jonco
https://hg.mozilla.org/mozilla-central/rev/0429fe76b4cc
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.