1513113 - Intermittent browser/components/payments/test/browser/browser_openPreferences.js | [JavaScript Error: "this.mm.content is null" {file: "resource:///modules/FaviconLoader.jsm" line: 498}]

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=216270431&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/TWU2YT8rSaSk3lxlczjy0Q/runs/0/artifacts/public/logs/live_backing.log

22:48:54     INFO - TEST-START | browser/components/payments/test/browser/browser_openPreferences.js
22:48:55     INFO - GECKO(4460) | JavaScript error: , line 0: AbortError: The operation was aborted.
22:48:55     INFO - TEST-INFO | started process screenshot
22:48:55     INFO - TEST-INFO | screenshot: exit 0
22:48:55     INFO - Buffered messages logged at 22:48:54
22:48:55     INFO - Entering test bound setup_head
22:48:55     INFO - Leaving test bound setup_head
22:48:55     INFO - Entering test bound setup_once
22:48:55     INFO - Leaving test bound setup_once
22:48:55     INFO - Entering test bound test_openPreferences
22:48:55     INFO - waitForMessageFromWidget: paymentDialogReady
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | requestId should be defined - 
22:48:55     INFO - Got paymentDialogReady from widget
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | Got payment widget - 
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | dialog should not be closed - 
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | Got payment frame - 
22:48:55     INFO - dialog ready
22:48:55     INFO - helper functions injected into frame
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | Visible string includes 'Preferences' - true == true - 
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | Visible string includes 'Options' - true == true - 
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | Preferences link should exist - {} == true - 
22:48:55     INFO - TEST-PASS | browser/components/payments/test/browser/browser_openPreferences.js | Ensure a tab was opened - 
22:48:55     INFO - Buffered messages logged at 22:48:55
22:48:55     INFO - Console message: [JavaScript Error: "AbortError: The operation was aborted. "]
22:48:55     INFO - Console message: [JavaScript Error: "this.mm.content is null" {file: "resource:///modules/FaviconLoader.jsm" line: 498}]
22:48:55     INFO - loadIcons@resource:///modules/FaviconLoader.jsm:498:9
22:48:55     INFO - FaviconLoader/this.iconTask<@resource:///modules/FaviconLoader.jsm:494:44
22:48:55     INFO - idleDispatch/</<@resource://gre/modules/PromiseUtils.jsm:40:21
22:48:55     INFO - 
22:48:55     INFO - Buffered messages finished
22:48:55     INFO - TEST-UNEXPECTED-FAIL | browser/components/payments/test/browser/browser_openPreferences.js | [JavaScript Error: "this.mm.content is null" {file: "resource:///modules/FaviconLoader.jsm" line: 498}]
22:48:55     INFO - loadIcons@resource:///modules/FaviconLoader.jsm:498:9
22:48:55     INFO - FaviconLoader/this.iconTask<@resource:///modules/FaviconLoader.jsm:494:44
22:48:55     INFO - idleDispatch/</<@resource://gre/modules/PromiseUtils.jsm:40:21
22:48:55     INFO -  - 
22:48:55     INFO - Stack trace:
22:48:55     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Dave, can you take a look at this, please?

https://hg.mozilla.org/mozilla-central/file/c10ccebf6647/browser/modules/FaviconLoader.jsm#l498

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1513113: Bail out of loading icons if the content page has unloaded. r=mak

There is a problem in FaviconLoader where we can attempt to load icons after the
page has been unloaded somehow. Because DeferredTask pushes its task to the idle
queue there is a short gap between when DeferredTask's timer fires and when its
task starts. If the page is unloaded in that gap we are unable to cancel the
task and when it starts it fails to access the content page.

However, when the page unloads we do clear the list of icons and since there is
no reason to do anything when the list of icons is empty we can just bail out
of the load task early and never try to touch the content page in this case.

Comment 3

[Dave Townsend [:mossop]]

This isn't a serious bug, it just causes an error to appear in the console. This test uses a console listener to fail if anything unexpected is logged though.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239271d26c0c
Bail out of loading icons if the content page has unloaded. r=mak

Comment 5

[Intermittent Failures Robot]

16 failures in 484 pushes (0.033 failures/push) were associated with this bug yesterday.

Repository breakdown:
* autoland: 6
* mozilla-inbound: 5
* try: 1
* mozilla-central: 4

Platform breakdown:
* windows10-64: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1513113&startday=2018-12-12&endday=2018-12-12&tree=all

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/239271d26c0c

Comment 7

[Intermittent Failures Robot]

36 failures in 2485 pushes (0.014 failures/push) were associated with this bug in the last 7 days.

This is the #48 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 3
* autoland: 14
* mozilla-inbound: 12
* mozilla-central: 7

Platform breakdown:
* windows10-64: 36

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1513113&startday=2018-12-10&endday=2018-12-16&tree=all