Closed Bug 1513134 Opened 1 year ago Closed 1 year ago

python configure lint doesn't complain about unnecessary --help dependencies

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox66 fixed)

RESOLVED FIXED
Tracking Status
firefox66 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(4 files)

as seen in bug 1512914
This is a not strictly necessary drive-by cleanup.
_imports is cleared of functions at runtime, and that can cause
the `func in self._imports` test to return False in cases where the
function *does* have imports.

Make the lint track which functions has imports on its own.

This fortunately didn't cause mistakes not being caught by the lint in
the current python configure code, but causes problems with upcoming
changes.

Depends on D14124
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/968eef77fcd1
Make ConfigureSandbox._apply_imports clear _imports itself. r=firefox-build-system-reviewers,gps
https://hg.mozilla.org/integration/autoland/rev/bcbedb817137
Don't rely on ConfigureSandbox._imports for the lint. r=firefox-build-system-reviewers,gps
https://hg.mozilla.org/integration/autoland/rev/0f7e4ff45912
Detect unnecessary --help dependencies. r=firefox-build-system-reviewers,gps
https://hg.mozilla.org/integration/autoland/rev/1cf8fafae8d8
Lint python/mozbuild/mozbuild/test/configure/data/moz.configure. r=firefox-build-system-reviewers,gps
You need to log in before you can comment on or make changes to this bug.