Setting guid (instead of keyword) for a bookmark in distribution.ini

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: hectorz, Assigned: hectorz)

Tracking

unspecified
Firefox 66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
Support for keyword with a bookmark was introduced in bug 1220547 to make it possible to query for these bookmarks for later updates.

However, we can only query it indirectly with the help of an url. I'd like to move it to something more uniquely related to a bookmark. With annotation gone and guid prefixes used in enterprise policy for similar purpose (bug 1428924), I'd like to switch to use guid in distribution.ini, too.

I've also spoken with :mkaply and no other partner repacks are using the keyword, so I intend to remove them in this bug.
Assignee

Comment 1

6 months ago
Also stop setting keyword with distribution.ini.
Assignee

Comment 2

6 months ago
(In reply to Hector Zhao [:hectorz] from comment #1)
> Created attachment 9033624 [details]
> Bug 1513162 - Use guid with known prefix for bookmarks from
> distribution.ini. r?mak,mkaply
> 
> Also stop setting keyword with distribution.ini.

Initially I wanted the ability to set arbitrary guid for each bookmark defined in distribution.ini, but once I began to prepare the patch, I'm not sure how to best handle exceptions like invalid characters, incorrect length (maybe padding and truncating?) and violation of the unique constraint (same sub folder included in both menu and toolbar?).

Then I realized, making sure these bookmarks have a known guid prefix (again, similar to bug 1428924) should be good enough for my own use case, and that's what I've implemented in this patch.
Attachment #9033624 - Attachment description: Bug 1513162 - Use guid with known prefix for bookmarks from distribution.ini. r?mak,mkaply → Bug 1513162 - Use guid with known prefix for bookmarks from distribution.ini. r?mak!,mkaply!

Comment 4

6 months ago

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0117afe25cfe
Use guid with known prefix for bookmarks from distribution.ini. r=mak,mkaply

Keywords: checkin-needed

Comment 5

6 months ago
bugherder
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.