1513162 - Setting guid (instead of keyword) for a bookmark in distribution.ini

Status: RESOLVED FIXED

(Firefox :: Distributions, enhancement)

Description

[Hector Zhao [:hectorz]]

Support for keyword with a bookmark was introduced in bug 1220547 to make it possible to query for these bookmarks for later updates.

However, we can only query it indirectly with the help of an url. I'd like to move it to something more uniquely related to a bookmark. With annotation gone and guid prefixes used in enterprise policy for similar purpose (bug 1428924), I'd like to switch to use guid in distribution.ini, too.

I've also spoken with :mkaply and no other partner repacks are using the keyword, so I intend to remove them in this bug.

Comment 1

[Hector Zhao [:hectorz]]

Attachment: Bug 1513162 - Use guid with known prefix for bookmarks from distribution.ini. r?mak!,mkaply!

Also stop setting keyword with distribution.ini.

Comment 2

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #1)
> Created attachment 9033624 [details]
> Bug 1513162 - Use guid with known prefix for bookmarks from
> distribution.ini. r?mak,mkaply
> 
> Also stop setting keyword with distribution.ini.

Initially I wanted the ability to set arbitrary guid for each bookmark defined in distribution.ini, but once I began to prepare the patch, I'm not sure how to best handle exceptions like invalid characters, incorrect length (maybe padding and truncating?) and violation of the unique constraint (same sub folder included in both menu and toolbar?).

Then I realized, making sure these bookmarks have a known guid prefix (again, similar to bug 1428924) should be good enough for my own use case, and that's what I've implemented in this patch.

Comment 3

[Hector Zhao [:hectorz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9abb1beef8814a24a6c28c62057bfd0c168ea91c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0117afe25cfe
Use guid with known prefix for bookmarks from distribution.ini. r=mak,mkaply

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0117afe25cfe