1513176 - mozglue.dll erroneously being reported as untrusted in untrusted modules ping

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Carl Corcoran [:ccorcoran]]

According to https://sql.telemetry.mozilla.org/queries/60448, the most frequent untrusted module being reported is mozglue.dll. From its trust flags (25), it looks like it should be trusted (it has the Mozilla digital signature).

Trust flags are defined here: https://searchfox.org/mozilla-central/rev/fd62b95c187a40b328d9e7fd9d848833a6942b57/toolkit/xre/ModuleEvaluator_windows.h#22

Comment 1

[Carl Corcoran [:ccorcoran]]

Attachment: Bug 1513176: Prevent mozglue.dll from appearing erroneously in the untrusted modules ping;r?aklotz

Nightly is reporting mozglue.dll as being untrusted in the untrusted modules
ping. Until now, xpcshell tests hard-code mozglue to appear as untrusted in
order to cover certain code paths related to startup modules.

This patch:
1. Checks explicitly for the xpcshell environment and only applies this logic
   during xpcshell tests.
2. Uses a purpose-build DLL, "untrusted-startup-test-dll.dll", instead of
   mozglue. This is more explicit and doesn't interfere with any "true"
   processing of mozglue.

Comment 2

[Carl Corcoran [:ccorcoran]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=060197d2b819800fd21ca12d4e9f0b14b8576db5

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ef3943abe13
Prevent mozglue.dll from appearing erroneously in the untrusted modules ping;r=aklotz

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9ef3943abe13

Comment 5

[Alfred Peters [:infofrommozilla]]

(In reply to Carl Corcoran [:ccorcoran] from comment #1)
> Created attachment 9031817 [details]

| -#if ENABLE_TESTS
[...]
|    int scoreThreshold = 100;
[...]
| +#ifdef ENABLE_TESTS
[...]
|  #else
|    static const int scoreThreshold = 100;

The last declaration is superfluous.

It causes a compiler error:

| 83:41.89 s:/Projects/mozi/mozilla/toolkit/xre/ModuleEvaluator_windows.cpp(221,20):  error: redefinition of 'scoreThreshold' with a different type: 'const int' vs 'int'
| 83:41.89   static const int scoreThreshold = 100;
| 83:41.89                    ^
| 83:41.89 s:/Projects/mozi/mozilla/toolkit/xre/ModuleEvaluator_windows.cpp(207,7):  note: previous definition is here
| 83:41.89   int scoreThreshold = 100;
| 83:41.89       ^