Mozmill failure on 2018-12-11: 3 failing tests, Mac failure only: testEventDialog.js, testEventDialogModificationPrompt.js, testUTF8.js

ASSIGNED
Assigned to

Status

defect
ASSIGNED
6 months ago
a month ago

People

(Reporter: jorgk, Assigned: Fallen, NeedInfo)

Tracking

({intermittent-failure, leave-open})

Details

(Whiteboard: [Thunderbird-testfailure: Z Mac only][Thunderbird-disabled-test])

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

6 months ago
+++ This bug was initially created as a clone of Bug #1513110 +++

TEST-UNEXPECTED-FAIL | [snip]/mozmill/eventDialog/testEventDialog.js | testEventDialog.js::testEventDialog
TEST-UNEXPECTED-FAIL | [snip]/mozmill/eventDialog/testEventDialogModificationPrompt.js | testEventDialogModificationPrompt.js::testEventDialogModificationPrompt
TEST-UNEXPECTED-FAIL | [snip]/mozmill/eventDialog/testUTF8.js | testUTF8.js::testUTF8

M-C last good: 68151063d1c63ce445d67aa743a018d7f6
M-C first bad: 13f891b92db19ea8ec85ef329eff7a793c
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=68151063d1c63ce445d67aa743a018d7f6&tochange=13f891b92db19ea8ec85ef329eff7a793c

Geoff already fixed 8 failing tests in bug 1513110. So for these failures the log
https://taskcluster-artifacts.net/IUKQSg8NQuWooshuXuE06A/0/public/logs/live_backing.log
says things like:

SUMMARY-UNEXPECTED-FAIL | testEventDialog.js | testEventDialog.js::testEventDialog
EXCEPTION: waitFor: Timeout exceeded for '() => !eventid("status-privacy-private-box").getNode().hasAttribute("collapsed")'

SUMMARY-UNEXPECTED-FAIL | testEventDialogModificationPrompt.js | testEventDialogModificationPrompt.js::testEventDialogModificationPrompt
EXCEPTION: Checkbox ID: event-all-day could not be checked/unchecked

SUMMARY-UNEXPECTED-FAIL | testUTF8.js | testUTF8.js::testUTF8
EXCEPTION: could not validate element ID: item-description with value  πŸ’£ πŸ’₯  ☣
Reporter

Comment 1

6 months ago
Could someone with a Mac please check out what's happening here. Maybe the screenshot facility helps.
Flags: needinfo?(philipp)
Flags: needinfo?(geoff)
Flags: needinfo?(arshdkhn1)
Reporter

Updated

6 months ago
Summary: Mozmill failure on 2018-12-11: 3 failing tests, Mac failure only → Mozmill failure on 2018-12-11: 3 failing tests, Mac failure only: testEventDialog.js, testEventDialogModificationPrompt.js, testUTF8.js
Just made a Try push with screenshots enabled. Will see if that helps.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0214102d2c62ef296fa2d33ed22305f40aab8444
Flags: needinfo?(geoff)
I think there's some timing issue here. In this screenshot, the first three letters typed are missing:

https://taskcluster-artifacts.net/EtQJgYNORzWe8V6hC7LtkA/0/public/test_info/testEventDialogModificationPrompt.js__testEventDialogModificationPrompt-pdpudM.png

In this one, we should've opened a popup and clicked on a value, but it hasn't happened:

https://taskcluster-artifacts.net/EtQJgYNORzWe8V6hC7LtkA/0/public/test_info/testEventDialog.js__testEventDialog-DHtEmP.png

(Side note, why is the default privacy set to confidential on Mac but on my Linux box confidential isn't even an option?)
The "category" and "until" boxes are also wrong in testEventDialog.js. What the heck is going on?
Comment hidden (Intermittent Failures Robot)
the dropdown button is missing for event dialog, maybe it might be the reason behind some of the failures.
Flags: needinfo?(arshdkhn1)
Posted patch 1513181-menulist-dropmarker.patch (obsolete) β€” β€” Splinter Review
I can't find which bug regressed this, but I think it was a de-XBL bug which changed the menulist[editable="true"].

I'm asking you because you are on a Mac and it also affects Calendar the time link images in event dialog.

It's also a bit of a UI review as the native menulist does no more work and I show the dropmarker like on Windows. Can a Mac user work like this?

I started also a try to check if it fixes the Mac test failures: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=374780427fd8457008c4219d074c7fee5956b912
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9031951 - Flags: review?(philipp)
Hmm, the failures are still there. :-(
While this is being looked at I'd like these extra checks to be added:

https://hg.mozilla.org/try-comm-central/rev/7cd9254c77a5bb1fb11c0d24d83d9d730f796d89

There's probably some more things that need checking too.
Reporter

Updated

5 months ago
Keywords: leave-open
Whiteboard: [Thunderbird-testfailure: Z Mac only] → [Thunderbird-testfailure: Z Mac only][Thunderbird-disabled-test]

Comment 10

5 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f9cf0cecc60c
disable three failing tests on Mac. rs=bustage-fix

I've debugged into this test to start:

SUMMARY-UNEXPECTED-FAIL | testEventDialog.js | testEventDialog.js::testEventDialog
EXCEPTION: waitFor: Timeout exceeded for '() => !eventid("status-privacy-private-box").getNode().hasAttribute("collapsed")'

The issue is that the private item is not actually selected by setData. If I comment out the line that attempts to close the popup, then I get past this step.

Maybe this is a pointer for someone to continue, I may have time later for more.

Comment on attachment 9031951 [details] [diff] [review]
1513181-menulist-dropmarker.patch

Moved this patch to a new bug 1519664 as it isn't the fix for the failures.

Attachment #9031951 - Flags: review?(philipp)
Attachment #9031951 - Attachment is obsolete: true
Assignee: richard.marti → nobody
Status: ASSIGNED → NEW
Posted patch Fix - v1 (obsolete) β€” β€” Splinter Review

This should help. setData was not setting all the fields, mostly because the popups were not closed properly. I've run the other mentioned tests and they magically work for me, so maybe it was related.

Assignee: nobody → philipp
Status: NEW → ASSIGNED
Flags: needinfo?(philipp)
Attachment #9036197 - Flags: review?(Mozilla)

Comment on attachment 9036197 [details] [diff] [review]
Fix - v1

I did a try run that really works, but it seems testUTF8 is failing. Back to the drawing board.

Attachment #9036197 - Attachment is obsolete: true
Attachment #9036197 - Flags: review?(Mozilla)
Reporter

Comment 16

a month ago

Philipp, any cycles for this? I see the tests are still disabled on Mac.

Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.