1513213 - Permafailing bustage on BytecodeEmitter.cpp:1519:3: error: use of undeclared identifier 'SprintfLiteral'

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Central as Beta:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=984f2e1e63d1c968f2120589cd6739c45bb5d8d3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=216350620&repo=try&lineNumber=984

[task 2018-12-11T12:59:43.733Z] In file included from /builds/worker/workspace/build/src/obj-spider/js/src/frontend/Unified_cpp_js_src_frontend0.cpp:20:0:
[task 2018-12-11T12:59:43.733Z] /builds/worker/workspace/build/src/js/src/frontend/BytecodeEmitter.cpp: In member function 'void js::frontend::BytecodeEmitter::reportNeedMoreArgsError(js::frontend::ParseNode*, const char*, const char*, const char*, const js::frontend::ListNode*)':
[task 2018-12-11T12:59:43.733Z] /builds/worker/workspace/build/src/js/src/frontend/BytecodeEmitter.cpp:1519:56: error: 'SprintfLiteral' was not declared in this scope
[task 2018-12-11T12:59:43.733Z]    SprintfLiteral(actualArgsStr, "%u", argsList->count());
[task 2018-12-11T12:59:43.733Z]                                                         ^
[task 2018-12-11T12:59:43.742Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name lazy_static /builds/worker/workspace/build/src/third_party/rust/lazy_static/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=4a937284be7a25f2 -C extra-filename=-4a937284be7a25f2 --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-12-11T12:59:43.816Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name utf8_ranges /builds/worker/workspace/build/src/third_party/rust/utf8-ranges/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=301602b28afc9155 -C extra-filename=-301602b28afc9155 --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-12-11T12:59:44.131Z]      Running `/builds/worker/workspace/rustc/bin/rustc --crate-name regex_syntax /builds/worker/workspace/build/src/third_party/rust/regex-syntax-0.4.1/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=2 -C panic=abort -C codegen-units=1 -C metadata=2e5ba39f3e3866a7 -C extra-filename=-2e5ba39f3e3866a7 --out-dir /builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./x86_64-unknown-linux-gnu/release/deps -L dependency=/builds/worker/workspace/build/src/obj-spider/js/src/frontend/binsource/./release/deps --cap-lints warn -C opt-level=2 -C debuginfo=2`
[task 2018-12-11T12:59:44.594Z] /builds/worker/workspace/build/src/config/rules.mk:1131: recipe for target 'Unified_cpp_js_src_frontend0.o' failed
[task 2018-12-11T12:59:44.594Z] make[3]: *** [Unified_cpp_js_src_frontend0.o] Error 1
[task 2018-12-11T12:59:44.594Z] make[3]: *** Waiting for unfinished jobs....
[task 2018-12-11T12:59:44.594Z] /builds/worker/workspace/gcc/bin/g++ -o Unified_cpp_js_src_wasm1.o -c  -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/wasm -I/builds/worker/workspace/build/src/obj-spider/js/src/wasm -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fomit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow  -MD -MP -MF .deps/Unified_cpp_js_src_wasm1.o.pp   /builds/worker/workspace/build/src/obj-spider/js/src/wasm/Unified_cpp_js_src_wasm1.cpp
[task 2018-12-11T12:59:48.313Z] make[3]: Leaving directory '/builds/worker/workspace/build/src/obj-spider/js/src/frontend'
[task 2018-12-11T12:59:48.314Z] /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'js/src/frontend/target' failed
[task 2018-12-11T12:59:48.314Z] make[2]: *** [js/src/frontend/target] Error 2
[task 2018-12-11T12:59:48.314Z] make[2]: *** Waiting for unfinished jobs....

:bzbarsky could you please take a look? Thank you.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Include the header we need for SprintfLiteral

Comment 2

[Boris Zbarsky [:bzbarsky]]

Natalia, thank you for catching this!

Comment 3

[Natalia Csoregi [:nataliaCs]]

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #2)
> Natalia, thank you for catching this!

Thank you for looking into this! :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1015d3b01f1c
Include the header we need for SprintfLiteral.  r=nbp

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1015d3b01f1c

Comment 6

[Natalia Csoregi [:nataliaCs]]

No more occurrences on the latest beta-simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe7edb749614ed4266acc5b6e41f8609bf165db3&group_state=expanded