Closed
Bug 1513298
Opened 5 years ago
Closed 4 years ago
Add a fingerprinting feature to the URL classifier
Categories
(Toolkit :: Safe Browsing, enhancement, P1)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: englehardt, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
22.43 KB,
patch
|
dimi
:
review+
|
Details | Diff | Splinter Review |
We should add a feature to the URL classifier that consumes the fingerprinting categorized list from shavar and cancels the channel.
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
Note that this patch cancels the channel using 'tracking-protection' error. So far, it's OK, but we need to use a different error when we know what the UI will look like.
Assignee: nobody → amarchesini
Attachment #9031808 -
Flags: review?(dlee)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Attachment #9031808 -
Attachment is obsolete: true
Attachment #9031808 -
Flags: review?(dlee)
Attachment #9031813 -
Flags: review?(dlee)
|
||
Updated•5 years ago
|
Component: Tracking Protection → Safe Browsing
Product: Firefox → Toolkit
|
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
|
|
Assignee | |
Comment 3•4 years ago
|
||
Attachment #9031813 -
Attachment is obsolete: true
Attachment #9031813 -
Flags: review?(dlee)
Attachment #9034538 -
Flags: review?(dlee)
|
|
||
Comment 4•4 years ago
|
||
Comment on attachment 9034538 [details] [diff] [review] feature_fingerprinting.patch Review of attachment 9034538 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! ::: modules/libpref/init/StaticPrefList.h @@ +1776,5 @@ > ) > > +// Block 3rd party fingerprinting resources. > +VARCACHE_PREF( > + "privacy.fingerprinting.enabled", Do you think we should use? privacy.trackingprotection.fingerprinting.enabled privacy.trackingprotection.cryptomining.enabled I think we should check with johann to see if he has any concern. ::: toolkit/components/url-classifier/tests/mochitest/test_fingerprinting.html @@ +38,5 @@ > + [ "urlclassifier.features.fingerprinting.blacklistTables", "" ], > + [ "urlclassifier.features.fingerprinting.whitelistTables", "" ], > + [ "privacy.trackingprotection.enabled", false ], > + [ "privacy.trackingprotection.annotate_channels", false ], > + [ "privacy.fingerprinting.enabled", true ], Can you help check if we can use [ "urlclassifier.features.fingerprinting.blacklistTables", "test-track-simple" ], with url trackertest.org... I feel safer if we really look into the tables, thanks!
Attachment #9034538 -
Flags: review?(dlee) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/76f3be6b25e1 Fingerprinting url-classifier feature, r=dimi
|
||
Comment 6•4 years ago
|
||
Backed out changeset 76f3be6b25e1 (Bug 1513298) for ES lint failure in test_fingerprinting.html CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220772211&repo=mozilla-inbound&lineNumber=252
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e57137ffb27d6f6b7c2a0575e9c46f770491088d
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a11f752f828c Fingerprinting url-classifier feature, r=dimi
|
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(amarchesini)
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•