1513298 - Add a fingerprinting feature to the URL classifier

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P1)

Description

[Steven Englehardt [:englehardt]]

We should add a feature to the URL classifier that consumes the fingerprinting categorized list from shavar and cancels the channel.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: feature_fingerprinting.patch

Note that this patch cancels the channel using 'tracking-protection' error. So far, it's OK, but we need to use a different error when we know what the UI will look like.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 3

[Andrea Marchesini [:baku]]

Attachment: feature_fingerprinting.patch

Comment 4

[Dimi Lee [ooo 16.04 - 21.04］]

Comment on attachment 9034538 [details] [diff] [review]
feature_fingerprinting.patch

Review of attachment 9034538 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: modules/libpref/init/StaticPrefList.h
@@ +1776,5 @@
>  )
>  
> +// Block 3rd party fingerprinting resources.
> +VARCACHE_PREF(
> +  "privacy.fingerprinting.enabled",

Do you think we should use?
privacy.trackingprotection.fingerprinting.enabled
privacy.trackingprotection.cryptomining.enabled

I think we should check with johann to see if he has any concern.

::: toolkit/components/url-classifier/tests/mochitest/test_fingerprinting.html
@@ +38,5 @@
> +    [ "urlclassifier.features.fingerprinting.blacklistTables", "" ],
> +    [ "urlclassifier.features.fingerprinting.whitelistTables", "" ],
> +    [ "privacy.trackingprotection.enabled", false ],
> +    [ "privacy.trackingprotection.annotate_channels", false ],
> +    [ "privacy.fingerprinting.enabled", true ],

Can you help check if we can use
[ "urlclassifier.features.fingerprinting.blacklistTables", "test-track-simple" ],
with url trackertest.org...

I feel safer if we really look into the tables, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f3be6b25e1
Fingerprinting url-classifier feature, r=dimi

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset 76f3be6b25e1 (Bug 1513298) for ES lint failure in test_fingerprinting.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=76f3be6b25e1398e4fdafd67cd2378f12f668b6f&selectedJob=220772211&searchStr=bf1813c891520f2ba58ac0e5c348b469a6fe7762

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220772211&repo=mozilla-inbound&lineNumber=252

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/e57137ffb27d6f6b7c2a0575e9c46f770491088d

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a11f752f828c
Fingerprinting url-classifier feature, r=dimi

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a11f752f828c