Closed Bug 1513300 Opened 5 years ago Closed 5 years ago

Add a cryptomining feature to the URL classifier

Categories

(Toolkit :: Safe Browsing, enhancement, P1)

Product:
Toolkit
Component:
Safe Browsing
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: englehardt, Assigned: baku)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

feature_cryptomining.patch
20.54 KB, patch
dimi
: review+
Details | Diff | Splinter Review 
We should add a feature to the URL classifier that consumes the cryptomining categorized list from shavar and cancels the channel.
Blocks: fpcmblocking
No longer blocks: 1511436
Depends on: 1511436
No longer depends on: fpcmblocking
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → amarchesini

        Attachment #9031814 -
        Flags: review?(dlee)

    
    

    
  
Comment on attachment 9031814 [details] [diff] [review]
patch

This patch is built on top of the fingerprinting feature. I want to see that one reviewed before asking here a review.

        Attachment #9031814 -
        Attachment is obsolete: true

        Attachment #9031814 -
        Flags: review?(dlee)

    
  
Component: Tracking Protection → Safe Browsing
Product: Firefox → Toolkit

    
  
Status: NEW → ASSIGNED
Priority: -- → P1

    
    

    
  


  

        Attachment #9034539 -
        Flags: review?(dlee)

    
    

    
  
Comment on attachment 9034539 [details] [diff] [review]

feature_cryptomining.patch


Review of attachment 9034539 [details] [diff] [review]:


Looks good to me, please also check the comment in fingerprinting, thanks!



        Attachment #9034539 -
        Flags: review?(dlee) → review+

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d503dc3fd033
Implement Cryptomining URL-Classifier, r=dimi

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d503dc3fd033


Status: ASSIGNED → RESOLVED
Closed: 5 years ago

          status-firefox66:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

          You need to log in
          before you can comment on or make changes to this bug.