1513373 - Add Twitter to tp6

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This tracks adding Twitter to tp6.

URL: https://twitter.com/BarackObama
Hero: Like icon for top tweet

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I don't believe we need to be logged in for this test to be valid, however we can create a test account if it's wanted.

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Bug 1513373 Add Twitter to tp6

Comment 3

[Florin Strugariu [:Bebe]]

And recording https://drive.google.com/open?id=1FQirDtcSrSDicKayfIdKhglJcKx3kOg4

Comment 4

[Robert Wood [:rwood]]

(In reply to Florin Strugariu [:Bebe] from comment #2)
> Created attachment 9031390 [details]
> Bug 1513373 Add Twitter to tp6

Thanks :bebe! Cool to see Twitter being added.

Raptor just times out with this patch because twitter.com wasn't added to the Raptor webext manifest (please test locally before submitting, thanks!). I updated the manifest locally and it worked great in Firefox and Chrome. Next steps - manifest update, then please provide the new updated tp6-7 recordings ZIP and NI me to to upload to tooltool. Then I'll get the manifest to you to add to your patch, and then you can push to try and see how it looks on Firefox and Chromium on all the platforms. :)

Comment 5

[Robert Wood [:rwood]]

Thanks for the update :bebe, works great on Firefox & Chrome with the update and page_timeout=45000. I'll upload to tooltool and post the info on phab.

Comment 6

[Florin Strugariu [:Bebe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2b90301015d23cef500dcc605c15c4d9c3ece6e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/283ebb9fc26f
Add Twitter to tp6 r=rwood

Comment 8

[Florin Strugariu [:Bebe]]

Leaving open to add to docs and Html info to repo

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/283ebb9fc26f

Comment 10

[Florin Strugariu [:Bebe]]

Leaving open to add to docs and Html info to repo

Comment 11

[Florin Strugariu [:Bebe]]

https://wiki.mozilla.org/Performance_sheriffing/Raptor#raptor-tp6-7

https://github.com/mozilla/perf-automation/pull/14