Closed Bug 1513373 Opened 10 months ago Closed 9 months ago

Add Twitter to tp6

Categories

(Testing :: Raptor, enhancement, P1)

Version 3
enhancement

Tracking

(firefox66 affected)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- affected

People

(Reporter: davehunt, Assigned: Bebe)

References

Details

Attachments

(1 file)

This tracks adding Twitter to tp6.

URL: https://twitter.com/BarackObama
Hero: Like icon for top tweet
I don't believe we need to be logged in for this test to be valid, however we can create a test account if it's wanted.
Assignee: nobody → fstrugariu
(In reply to Florin Strugariu [:Bebe] from comment #2)
> Created attachment 9031390 [details]
> Bug 1513373 Add Twitter to tp6

Thanks :bebe! Cool to see Twitter being added.

Raptor just times out with this patch because twitter.com wasn't added to the Raptor webext manifest (please test locally before submitting, thanks!). I updated the manifest locally and it worked great in Firefox and Chrome. Next steps - manifest update, then please provide the new updated tp6-7 recordings ZIP and NI me to to upload to tooltool. Then I'll get the manifest to you to add to your patch, and then you can push to try and see how it looks on Firefox and Chromium on all the platforms. :)
Flags: needinfo?(fstrugariu)
Thanks for the update :bebe, works great on Firefox & Chrome with the update and page_timeout=45000. I'll upload to tooltool and post the info on phab.
Flags: needinfo?(fstrugariu)
Leaving open to add to docs and Html info to repo
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/283ebb9fc26f
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Leaving open to add to docs and Html info to repo
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Priority: -- → P1
Status: REOPENED → RESOLVED
Closed: 10 months ago9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.