Closed Bug 1513434 Opened 1 year ago Closed 1 year ago

Remove use of `XPCOMUtils.IterSimpleEnumerator` in `nsUpdateService`

Categories

(Toolkit :: Application Update, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: Lina, Assigned: Lina)

References

Details

Attachments

(1 file)

I was looking at bug 1484496 (for non-updater reasons :-)), and spotted a call to `XPCOMUtils.IterSimpleEnumerator` in https://searchfox.org/mozilla-central/rev/adcc169dcf58c2e45ba65c4ed5661d666fc3ac74/toolkit/mozapps/update/nsUpdateService.js#3239-3240, which no longer exists. Bug 1484496, comment 44 also mentions this; the `try...catch` around the block masked the type error.

I'm not really sure how to go about testing this, but it seemed like an easy fix to do on the train home.

Lina, is this ready to land? I came across this bug today. The patch still applies.

Flags: needinfo?(lina)
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c84c91cc9c5b
Remove use of `XPCOMUtils.IterSimpleEnumerator` in `nsUpdateService`. r=keeler
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

I forgot to land this after it was r+'ed. >.> Thanks, Andrew!

Flags: needinfo?(lina)
You need to log in before you can comment on or make changes to this bug.