Closed
Bug 1513487
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14475 - Revert "Fix SVG-As-Background sizing"
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox66 fixed)
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14475 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14475 Details from upstream follow. Shuotao Gao <stgao@chromium.org> wrote: > Revert "Fix SVG-As-Background sizing" > > This reverts commit aed99d7e12bd036ab3ebb4fe522ce8faf347a32f. > > Reason for revert: Speculative revert for the compile failure on Android and ChromeOS, because this CL is the single CL that shows up in the blamelist of both failed builds. > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/5507 > https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59554 > > Original change's description: > > Fix SVG-As-Background sizing > > > > Addresses a TODO where we were snapping the intrinsic size of an SVG image, > > even when that is no longer useful. This was posing issues with operations > > using aspect ratio, because the computed aspect ratio on the snapped value > > was wrong when then used on un-snapped values. > > > > R=fs@opera.com > > BUG=855882 > > > > Change-Id: I0c14c0109da4c5ca5e52aebf408e9b702eda799c > > Reviewed-on: https://chromium-review.googlesource.com/c/1370486 > > Commit-Queue: Stephen Chenney \<schenney@chromium.org> > > Reviewed-by: Fredrik Söderquist \<fs@opera.com> > > Cr-Commit-Position: refs/heads/master@{#615798} > > TBR=fs@opera.com,schenney@chromium.org > > Change-Id: I6bd43ac3ad23393be353249657566e9080cd69c0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 855882 > Reviewed-on: https://chromium-review.googlesource.com/c/1373285 > Reviewed-by: Shuotao Gao \<stgao@chromium.org> > Commit-Queue: Shuotao Gao \<stgao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615831} >
Assignee | ||
Comment 1•5 years ago
|
||
PR 14475 applied with additional changes from upstream: 39f6169dae5bafb2f5d5d5b4a6595e20d63337b7
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=619b9646f9541b4b8a743f0f316d950dd9b612c4
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/39b4f64875f6 [wpt PR 14475] - Revert "Fix SVG-As-Background sizing", a=testonly
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•